Progress bar gbq #22399
Closed
Progress bar gbq #22399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @bagmanas! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on August 17, 2018 at 17:24 Hours UTC |
|
Does this reference a particular issue number? |
|
No. This is the problem I faced an hour ago.) |
pep8
|
Ok please be sure to open an issue first before making any code changes. I’m not entirely sure what this is from limited gbq knowledge but tests are required as well |
|
Do we have a minimum version for pandas-gbq? Looks like this was added in 0.5. |
|
#21628 Looks like the relevant changes have been made in this PR. I think we are good to close this one. @WillAyd @TomAugspurger |
|
Still need an issue to be opened for this along with the relevant test case(s) |
|
@alimcmaster1 ah thanks for the link. Looks like it - closing as duplicative |
WillAyd
added
Duplicate Report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add variable for progress bar