Update observing methods #1175
Merged
Update observing methods #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changes `observatory.observe` to `observatory.take_observation` to have more descriptive name and not interfere with potential state action names. * `take_observation` will now remove cameras if they are stuck and try to continue observing until no cameras are left. * Created high-level `pocs.observe_target`, which loops over the exptimes in the observation and sets up processing threads when done with each exposure. This replaces what was in the `observing` state and moves it to a `pocs` method. This allows the mount to stay on a target for the length of the observation without moving between states during each exposures, which helps cadence.
Codecov Report
@@ Coverage Diff @@
## develop #1175 +/- ##
===========================================
- Coverage 83.08% 74.80% -8.29%
===========================================
Files 86 91 +5
Lines 7425 7846 +421
Branches 635 877 +242
===========================================
- Hits 6169 5869 -300
- Misses 1083 1834 +751
+ Partials 173 143 -30
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
observatory.observetoobservatory.take_observationto have more descriptive name and not interfere with potential state action names.take_observationwill now remove cameras if they are stuck and try to continue observing until no cameras are left.pocs.observe_target, which loops over the exptimes in the observation and sets up processing threads when done with each exposure. This replaces what was in theobservingstate and moves it to apocsmethod. This allows the mount to stay on a target for the length of the observation without moving between states during each exposures, which helps cadence.Relies on python 3.10 from Create scheduler updates #1174Comes from #1167