test: add a test of creating a foreign table with reserved column name #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
THANK YOU for making this 🙏 Could you please write a test using the same column name as the user's to make sure it is fixed? |
kysshsy
force-pushed
the
fix_reserved_column
branch
from
060fc14 to
9c0f756
Compare
kysshsy
changed the title
Yeah, I added a test of creating a table with reserved column name 'authorization' |
kysshsy
changed the title
Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
Why
How
Add the option preserve_casing 'true' to ensure that reserved column names are correctly created.
Tests
add a test of creating foreign table with reserved column name