refactor: streamlining DimIsNone
trait and optimizing parse_u256_types
#153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The primary goal of these changes is to enhance the readability and efficiency of the code in the
Args
struct. In its previous state, certain functions likedim_is_none
andparse_u256_types
were more verbose than necessary and did not fully leverage Rust's expressive capabilities. By refactoring these functions, we aim to make the codebase cleaner, more maintainable, and easier for other contributors to understand and work with.Solution
DimIsNone
Trait Refactoring:dim_is_none
function by returning the negation ofdim_is_some
, thereby removing redundant match statements.parse_u256_types
Function Optimization:map_or
andmap
for more idiomatic and streamlined logic.These changes maintain the existing functionality while significantly enhancing code quality.