CI: sign apk with present in repo debug key #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workflow reuses already existing in repo debug key in debug.keystore. I understand that this key can be used by anyone to sign any apk, but I don't think it should bother us. On our side this key is only going to be used for signing CI builds, so an malefactor could use this key only to replace installed from CI artifact DSUB to a malicous DSUB, I think it's unlikely somebody going to target this. Especially after we get DSub2000 to fdroid. Additionally, this would allow for third-party forks to provide builds, compatible with ours. Thus allowing for users to switch between forks of their choice, if desired. Also, it appers step setup-android isn't required, the flow works without it, so deleting it.
|
if needed, we can also use github secrets to use a private keystore as described in: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially closes #22
This workflow reuses already existing in repo debug key in debug.keystore. I understand that this key can be used by anyone to sign any apk, but I don't think it should bother us. On our side this key is only going to be used for signing CI builds, so an malefactor could use this key only to replace installed from CI artifact DSUB to a malicious DSUB, I think it's unlikely somebody going to target this. Especially after we get DSub2000 to fdroid.
Additionally, this would allow for third-party forks to provide builds, compatible with ours. Thus allowing for users to switch between forks of their choice, if desired.
Also, it appears step setup-android isn't required, the flow works without it, so deleting it.