fix: Select input name instead of file in ParseFile (#1012)

parse-community · Oct 16, 2024 · 2876168 · 2876168
1 parent 3274981
commit 2876168
Show file tree

Hide file tree

Showing 7 changed files with 48 additions and 4 deletions.
diff --git a/packages/dart/CHANGELOG.md b/packages/dart/CHANGELOG.md
@@ -1,3 +1,9 @@
+## [7.0.1](https://github.com/parse-community/Parse-SDK-Flutter/compare/dart-7.0.0...dart-7.0.1) (2024-10-16)
+
+### Bug Fixes
+
+* Select input name instead of file in `ParseFile` ([#1012](https://github.com/parse-community/Parse-SDK-Flutter/pull/1012))
+
 ## [7.0.0](https://github.com/parse-community/Parse-SDK-Flutter/compare/dart-6.4.0...dart-7.0.0) (2024-04-12)
 
 ### BREAKING CHANGES

diff --git a/packages/dart/lib/src/base/parse_constants.dart b/packages/dart/lib/src/base/parse_constants.dart
@@ -1,7 +1,7 @@
 part of '../../parse_server_sdk.dart';
 
 // Library
-const String keySdkVersion = '7.0.0';
+const String keySdkVersion = '7.0.1';
 const String keyLibraryName = 'Flutter Parse SDK';
 
 // End Points

diff --git a/packages/dart/lib/src/objects/parse_file.dart b/packages/dart/lib/src/objects/parse_file.dart
@@ -11,7 +11,7 @@ class ParseFile extends ParseFileBase {
       super.client,
       super.autoSendSessionId})
       : super(
-          name: file != null ? path.basename(file.path) : name!,
+          name: name ?? path.basename(file?.path ?? ''),
         );
 
   File? file;

diff --git a/packages/dart/lib/src/objects/parse_x_file.dart b/packages/dart/lib/src/objects/parse_x_file.dart
@@ -11,7 +11,7 @@ class ParseXFile extends ParseFileBase {
       super.client,
       super.autoSendSessionId})
       : super(
-          name: file != null ? path.basename(file.path) : name!,
+          name: name ?? path.basename(file?.path ?? ''),
         );
 
   XFile? file;

diff --git a/packages/dart/pubspec.yaml b/packages/dart/pubspec.yaml
@@ -1,6 +1,6 @@
 name: parse_server_sdk
 description: The Dart SDK to connect to Parse Server. Build your apps faster with Parse Platform, the complete application stack.
-version: 7.0.0
+version: 7.0.1
 homepage: https://parseplatform.org
 repository: https://github.com/parse-community/Parse-SDK-Flutter
 issue_tracker: https://github.com/parse-community/Parse-SDK-Flutter/issues

diff --git a/packages/dart/test/src/objects/parse_file_test.dart b/packages/dart/test/src/objects/parse_file_test.dart
@@ -0,0 +1,19 @@
+import 'dart:io';
+import 'package:parse_server_sdk/parse_server_sdk.dart';
+import 'package:test/test.dart';
+
+import '../../test_utils.dart';
+
+void main() {
+  setUpAll(() async {
+    await initializeParse();
+  });
+
+  group('Parse X File', () {
+    test('should return a correct name', () {
+      File file = File('/sdcard/aa/aa.jpg');
+      final parseFile = ParseFile(file, name: 'bb.jpg');
+      expect(parseFile.name, 'bb.jpg');
+    });
+  });
+}
diff --git a/packages/dart/test/src/objects/parse_x_file_test.dart b/packages/dart/test/src/objects/parse_x_file_test.dart
@@ -0,0 +1,19 @@
+import 'package:cross_file/cross_file.dart';
+import 'package:parse_server_sdk/parse_server_sdk.dart';
+import 'package:test/test.dart';
+
+import '../../test_utils.dart';
+
+void main() {
+  setUpAll(() async {
+    await initializeParse();
+  });
+
+  group('Parse X File', () {
+    test('should return a correct name', () {
+      XFile file = XFile('/sdcard/aa/aa.jpg');
+      final parseFile = ParseXFile(file, name: 'bb.jpg');
+      expect(parseFile.name, 'bb.jpg');
+    });
+  });
+}