Release 1.0.27 - Pre-release process

- Static analysis fixes
parse-community · Aug 28, 2020 · b695f37 · b695f37
1 parent 039cf29
commit b695f37
Show file tree

Hide file tree

Showing 6 changed files with 29 additions and 18 deletions.
diff --git a/example/lib/pages/home_page.dart b/example/lib/pages/home_page.dart
@@ -41,7 +41,7 @@ class _HomePageState extends State<HomePage> {
             title: const Text('Parse Server demo'),
             actions: <Widget>[
               FlatButton(
-                  child: Text('Logout',
+                  child: const Text('Logout',
                       style: TextStyle(fontSize: 17.0, color: Colors.white)),
                   onPressed: () async {
                     final ParseUser user = await ParseUser.currentUser();

diff --git a/example_livelist/lib/main.dart b/example_livelist/lib/main.dart
@@ -172,7 +172,7 @@ class _ObjectFormState extends State<ObjectForm> {
                 ],
               ),
               trailing: IconButton(
-                  icon: Icon(Icons.save),
+                  icon: const Icon(Icons.save),
                   onPressed: () {
                     setState(() {
                       _formKey.currentState.save();

diff --git a/lib/src/data/parse_subclass_handler.dart b/lib/src/data/parse_subclass_handler.dart
@@ -47,8 +47,12 @@ class ParseSubClassHandler {
   }
 
   ParseObject createObject(String classname) {
-    if (classname == keyClassUser) return createParseUser(null, null, null);
-    if (_subClassMap.containsKey(classname)) return _subClassMap[classname]();
+    if (classname == keyClassUser) {
+      return createParseUser(null, null, null);
+    }
+    if (_subClassMap.containsKey(classname)) {
+      return _subClassMap[classname]();
+    }
     return ParseObject(classname);
   }
 

diff --git a/lib/src/network/parse_query.dart b/lib/src/network/parse_query.dart
@@ -301,7 +301,7 @@ class QueryBuilder<T extends ParseObject> {
   // Add a constraint to the query that requires a particular key's value matches a value for a key in the results of another ParseQuery.
   // ignore: always_specify_types
   void whereMatchesKeyInQuery(
-      String column, String keyInQuery, QueryBuilder query) {
+      String column, String keyInQuery, QueryBuilder<T> query) {
     if (query.queries.isEmpty) {
       throw ArgumentError('query conditions is required');
     }
@@ -322,7 +322,7 @@ class QueryBuilder<T extends ParseObject> {
   // Add a constraint to the query that requires a particular key's value does not match any value for a key in the results of another ParseQuery
   // ignore: always_specify_types
   void whereDoesNotMatchKeyInQuery(
-      String column, String keyInQuery, QueryBuilder query) {
+      String column, String keyInQuery, QueryBuilder<T> query) {
     if (query.queries.isEmpty) {
       throw ArgumentError('query conditions is required');
     }

diff --git a/lib/src/objects/response/parse_response_builder.dart b/lib/src/objects/response/parse_response_builder.dart
@@ -151,6 +151,6 @@ class _ParseResponseBuilder {
   }
 
   bool isHealthCheck(Response apiResponse) {
-    return ['{\"status\":\"ok\"}', 'OK'].contains(apiResponse.body);
+    return <String>['{\"status\":\"ok\"}', 'OK'].contains(apiResponse.body);
   }
 }
diff --git a/lib/src/utils/parse_live_list.dart b/lib/src/utils/parse_live_list.dart
@@ -256,7 +256,9 @@ class ParseLiveList<T extends ParseObject> {
 
   static Future<void> _loadIncludes(ParseObject object,
       {ParseObject oldObject, Map<String, dynamic> paths}) async {
-    if (object == null || paths == null || paths.isEmpty) return;
+    if (object == null || paths == null || paths.isEmpty) {
+      return;
+    }
 
     final List<Future<void>> loadingNodes = <Future<void>>[];
 
@@ -284,11 +286,13 @@ class ParseLiveList<T extends ParseObject> {
                   .then<void>((ParseResponse parseResponse) {
                 if (parseResponse.success &&
                     parseResponse.results.length == 1) {
+                  // ignore: deprecated_member_use_from_same_package
                   object.getObjectData()[key] = parseResponse.results[0];
                 }
               }));
               continue;
             } else {
+              // ignore: deprecated_member_use_from_same_package
               object.getObjectData()[key] = includedObject;
               //recursion
               loadingNodes
@@ -305,6 +309,7 @@ class ParseLiveList<T extends ParseObject> {
             loadingNodes.add(
                 queryBuilder.query().then<void>((ParseResponse parseResponse) {
               if (parseResponse.success && parseResponse.results.length == 1) {
+                // ignore: deprecated_member_use_from_same_package
                 object.getObjectData()[key] = parseResponse.results[0];
               }
             }));
@@ -331,7 +336,7 @@ class ParseLiveList<T extends ParseObject> {
       // ignore: avoid_as
       if ((includes[key] as Map<String, dynamic>).isNotEmpty) {
         includeList
-            .addAll(_toIncludeStringList(includes[key]).map((e) => '$key.$e'));
+            .addAll(_toIncludeStringList(includes[key]).map((String e) => '$key.$e'));
       }
     }
     return includeList;
@@ -343,7 +348,9 @@ class ParseLiveList<T extends ParseObject> {
     //(Hide first element, hide second, view first, view second => second is displayed twice)
     object = object?.clone(object?.toJson(full: true));
 
-    if (!fetchedIncludes) await _loadIncludes(object, paths: _includePaths);
+    if (!fetchedIncludes) {
+      await _loadIncludes(object, paths: _includePaths);
+    }
     for (int i = 0; i < _list.length; i++) {
       if (after(object, _list[i].object) != true) {
         _list.insert(
@@ -604,6 +611,7 @@ class ParseLiveListElement<T extends ParseObject> {
           _subscriptionQueue.whenComplete(() async {
             await ParseLiveList._loadIncludes(newObject,
                 oldObject: subObject, paths: _toKeyMap(path));
+            // ignore: deprecated_member_use_from_same_package
             parentObject.getObjectData()[currentKey.key] = newObject;
             if (!_streamController.isClosed) {
               _streamController
@@ -667,21 +675,20 @@ class ParseLiveListElement<T extends ParseObject> {
       if (subObject?.containsKey(keyVarUpdatedAt) == true) {
         final QueryBuilder<ParseObject> queryBuilder =
             QueryBuilder<ParseObject>(subObject)
-              ..keysToReturn([keyVarUpdatedAt])
+              ..keysToReturn(<String>[keyVarUpdatedAt])
               ..whereEqualTo(keyVarObjectId, subObject.objectId);
-        ParseResponse parseResponse = await queryBuilder.query();
-        if (parseResponse.success &&
-            (parseResponse.results.first as ParseObject).updatedAt !=
+        final ParseResponse parseResponse = await queryBuilder.query();
+        if (parseResponse.success && parseResponse.results.first.updatedAt !=
                 subObject.updatedAt) {
-          queryBuilder.limiters.remove("keys");
+          queryBuilder.limiters.remove('keys');
           queryBuilder.includeObject(_getIncludeList(path[key]));
-          ParseResponse parseResponse = await queryBuilder.query();
+          final ParseResponse parseResponse = await queryBuilder.query();
           if (parseResponse.success) {
             subObject = parseResponse.result.first;
 //            root.getObjectData()[key.key] = subObject;
-            if (key.subscription?.eventCallbacks?.containsKey("update") ==
+            if (key.subscription?.eventCallbacks?.containsKey('update') ==
                 true) {
-              key.subscription.eventCallbacks["update"](subObject);
+              key.subscription.eventCallbacks['update'](subObject);
             }
 //            key.subscription.eventCallbacks["update"](subObject);
             break;