Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Node 18, 20 drop support for Node 12 #137

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 6, 2023

https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md#nodejs

There was a fix in the http2 module to correctly handle errors. Before we had to parse the error in the end event now its handled on error emitter on client requests.

Closes: #132

This PR is referencing #131, which has now been closed.

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a25c835) 93.53% compared to head (9370b2f) 93.53%.
Report is 1 commits behind head on master.

❗ Current head 9370b2f differs from pull request most recent head e831e6f. Consider uploading reports for the commit e831e6f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          23       23           
  Lines         588      588           
=======================================
  Hits          550      550           
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza changed the title feat: Add support for Node 18, 20 drop support for Node 12 feat: Add support for Node 18, 20 drop support for Node 12, 14 Oct 19, 2023
@mtrezza mtrezza changed the title feat: Add support for Node 18, 20 drop support for Node 12, 14 feat: Add support for Node 18, 20 drop support for Node 12 Oct 19, 2023
@mtrezza mtrezza merged commit f203bc1 into parse-community:master Oct 19, 2023
4 checks passed
parseplatformorg pushed a commit that referenced this pull request Oct 19, 2023
# [6.0.0](5.2.3...6.0.0) (2023-10-19)

### Features

* Add support for Node 18, 20 drop support for Node 12 ([#137](#137)) ([f203bc1](f203bc1))

### BREAKING CHANGES

* This release removes support for Node 12; the minimum required version is Node 14. ([f203bc1](f203bc1))
@parseplatformorg
Copy link

🎉 This change has been released in version 6.0.0

@wojtekmaj
Copy link

https://github.com/parse-community/node-apn/blob/master/package.json#L68 package.json engines was still left out :)

@mtrezza
Copy link
Member

mtrezza commented Oct 20, 2023

@wojtekmaj Thanks, you are right, do you want to open a quick PR?

@wojtekmaj
Copy link

@mtrezza Done. Also, repository settings must be updated to require new tests and unrequire removed ones, but that needs to be done by the maintainer :)

@mtrezza
Copy link
Member

mtrezza commented Oct 20, 2023

Thanks, done in #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Node 18, 20
4 participants