-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Node 18, 20 drop support for Node 12 #137
Conversation
Thanks for opening this pull request! |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #137 +/- ##
=======================================
Coverage 93.53% 93.53%
=======================================
Files 23 23
Lines 588 588
=======================================
Hits 550 550
Misses 38 38 ☔ View full report in Codecov by Sentry. |
🎉 This change has been released in version 6.0.0 |
https://github.com/parse-community/node-apn/blob/master/package.json#L68 package.json engines was still left out :) |
@wojtekmaj Thanks, you are right, do you want to open a quick PR? |
@mtrezza Done. Also, repository settings must be updated to require new tests and unrequire removed ones, but that needs to be done by the maintainer :) |
Thanks, done in #138 |
https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md#nodejs
There was a fix in the http2 module to correctly handle errors. Before we had to parse the error in the
end
event now its handled onerror
emitter on client requests.Closes: #132
This PR is referencing #131, which has now been closed.