Psg 4901 use repo templates #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les in favour of org-level files
jenn-macfarlane
commented
Oct 22, 2024
README.md
Outdated
|
|
||
| Add an Android and/or iOS app in the Native Apps section. |
There was a problem hiding this comment.
I think it makes sense to pull up these more detailed prereq steps into this section. We can delete them/edit what we have in the actual html template when we remove after we have this enshrined in docs.
jenn-macfarlane
commented
Oct 22, 2024
README.md
Outdated
|
|
||
| See our [Passkey Complete documentation](https://docs.passage.id/complete/cross-platform-passkey-configuration/cross-platform-ios-configuration) for setting up a React Native app for passkeys and Passage. | ||
|
|
||
| #### Hosted associated domains files |
There was a problem hiding this comment.
This felt right to put in this section as well
jenn-macfarlane
commented
Oct 22, 2024
README.md
Outdated
| ``` | ||
|
|
||
| ### Go Passwordless | ||
|
|
||
| Find all more details about Passkey Flex on our [Passkey Flex Documentation](https://docs.passage.id/flex) page. |
There was a problem hiding this comment.
Because we don't have docs, figured I'd link to the Flex docs homepage.
jenn-macfarlane
commented
Oct 22, 2024
|
|
||
| Find all more details about Passkey Flex on our [Passkey Flex Documentation](https://docs.passage.id/flex) page. | ||
|
|
||
| # API Reference |
There was a problem hiding this comment.
Follows what we do in passage-react in the web monorepo
|
I really like the approach here! I also added a suggestion via commit, @jenn-macfarlane! Open to your thoughts, but my goal was to simplify the initial view of the README a bit more 😄 |
|
@agebhardt looks good to me! |
agebhardt
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New?
Uses repo templates to format README, LICENSE, and remove community files in favour of using organization community files.
Note
This repo contains documentation we do not yet have in our docs platform - I've integrated it as best I could to keep it somewhat in line with the template and preserving details.
Screenshots (if appropriate):
Type of change
Checklist:
Additional context
Add any other context or screenshots about the pull request here.