Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alert): add pf-alert #2593

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

feat(alert): add pf-alert #2593

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
33afe49
feat: init commit with pf-alert
brianferry Aug 28, 2023
df55c1d
feat: truncated title and timeout
brianferry Sep 11, 2023
6185d07
feat(alert): adding plain, custom icons
brianferry Sep 15, 2023
20eaf92
Merge branch 'main' of github.com:patternfly/patternfly-elements into…
brianferry Sep 25, 2023
544a0c6
feat(alert): cleaning up css, fallback variables for important styles…
brianferry Sep 29, 2023
c68683a
feat(core): adding isEmpty, hasSlotted w/ default slot
brianferry Oct 10, 2023
da3c824
chore: adding changeset
brianferry Oct 10, 2023
4a1dacf
Merge branch 'feat/core-default-slot' of github.com:patternfly/patter…
brianferry Oct 10, 2023
9a03851
Update core/pfe-core/controllers/slot-controller.ts
brianferry Oct 11, 2023
147b672
chore: merging with feat/default-slot
brianferry Oct 11, 2023
e1cfe19
fix(core): adding anonymous slot back to SlotController
brianferry Oct 11, 2023
88e079d
Merge branch 'feat/core-default-slot' of github.com:patternfly/patter…
brianferry Oct 11, 2023
8e2cd9e
feat(alert): multiple demos, jsdocs, adding pf-icon
brianferry Oct 13, 2023
d97a4f7
fix(alert): private css variables, moving ICONS call inline, removing…
brianferry Oct 16, 2023
472fa59
docs(alert): inline scripts, heading tags fixing
brianferry Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/pfe-core/controllers/slot-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,10 @@ export class SlotController implements ReactiveController {
}
}

hasAnonymousSlot(): boolean {
brianferry marked this conversation as resolved.
Show resolved Hide resolved
return this.#nodes.get(SlotController.anonymous)?.hasContent ?? false;
}

/**
* Given a slot name or slot names, returns elements assigned to the requested slots as an array.
* If no value is provided, it returns all children not assigned to a slot (without a slot attribute).
Expand Down
61 changes: 54 additions & 7 deletions elements/pf-alert/demo/pf-alert.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,45 @@
<link rel="stylesheet" href="demo.css">
<script type="module" src="pf-alert.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline


<pf-alert title="Default"></pf-alert>
<pf-alert variant="info" title="Info"></pf-alert>
<pf-alert variant="success" title="Success"></pf-alert>
<pf-alert variant="warning" title="Warning"></pf-alert>
<pf-alert variant="danger" title="Danger"></pf-alert>
<pf-alert title="Default alert title"></pf-alert>
brianferry marked this conversation as resolved.
Show resolved Hide resolved
<pf-alert variant="info" title="Info alert title"></pf-alert>
<pf-alert variant="success" title="Success alert title"></pf-alert>
<pf-alert variant="warning" title="Warning alert title"></pf-alert>
<pf-alert variant="danger" title="Danger alert title"></pf-alert>

<h1>
Alert Variations
</h1>

<pf-alert title="Success alert title" variant="success" dismissable>
<p>Success alert description. This should tell the user more information about the alert.</p>
<button slot="actions">View details</button>
<button slot="actions">Ignore</button>
</pf-alert>

<pf-alert title="Success alert title" variant="success" dismissable>
<p>Success alert description. This should tell the user more information about the alert. <a href="#">This is a link.</a></p>
<p>Success alert description. This should tell the user more information about the alert. <a href="#">This is a link.</a></p>
</pf-alert>

<pf-alert title="Success alert title" variant="success" dismissable>
<button slot="actions">View details</button>
<button slot="actions">Ignore</button>
</pf-alert>

<pf-alert title="Success alert title" variant="success" dismissable>

<p>Success alert description. This should tell the user more information about the alert. <a href="#">This is a link.</a></p>
<p>Success alert description. This should tell the user more information about the alert. <a href="#">This is a link.</a></p>
<button slot="actions">View details</button>
<button slot="actions">Ignore</button>
<button slot="actions">Ignore</button>
<button slot="actions">Ignore</button>
<button slot="actions">Ignore</button>
<button slot="actions">Ignore</button>
</pf-alert>

<pf-alert title="Success alert title" variant="success" dismissable></pf-alert>

<h1>
Default Icons
Expand Down Expand Up @@ -33,7 +67,10 @@ <h1>

<pf-alert title="Default plain" plain></pf-alert>
<pf-alert variant="info" title="Info plain" plain></pf-alert>
<pf-alert variant="success" title="Success plain" plain></pf-alert>
<pf-alert variant="success" title="Success plain" plain dismissable>
<p>Success alert description. This should tell the user more information about the alert. <a href="#">This is a link.</a></p>
<button slot="actions">Ignore</button>
</pf-alert>
<pf-alert variant="warning" title="Warning plain" plain></pf-alert>
<pf-alert variant="danger" title="Danger plain" plain></pf-alert>

Expand All @@ -48,7 +85,17 @@ <h1>
<pf-alert variant="danger" title="Danger inline" inline></pf-alert>

<h1>
Inline
Plain
</h1>

<pf-alert title="Default inline" plain></pf-alert>
<pf-alert variant="info" title="Info inline" plain></pf-alert>
<pf-alert variant="success" title="Success inline" plain></pf-alert>
<pf-alert variant="warning" title="Warning inline" plain></pf-alert>
<pf-alert variant="danger" title="Danger inline" plain></pf-alert>

<h1>
Inline Plain
</h1>

<pf-alert title="Default inline" inline plain></pf-alert>
Expand Down
Loading
Loading