chore: upgrade Yarn to the latest version #4413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlabaj
approved these changes
Dec 11, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Jon Koops <[email protected]>
jonkoops
force-pushed
the
upgrade-yarn
branch
from
0c74603 to
2c554ef
Compare
|
I've rebased the PR on top of Either way, nothing has changed in terms of dependency versions, so this should not really be a reason to hold this up, marking this as ready to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Yarn to a version that is not end-of-life. This PR is a reworked version of #4387, which ran into issues after merging. This turned out to be because of a bad rebase, which caused the versions of
@patternfly/documentation-frameworkto be out of sync (a common issue that happens onmainas well).This version improves over the original PR as the
@patternfly/documentation-frameworkpackage is now using the workspace protocol, meaning it will never be out of sync again, as it is directly linked to the version present in the workspace. This also mitigates the need to manually bump this version when it is changed.Note the CI will likely fail for the reasons outlined under #4387 (comment) due to Corepack not being present onmain. I will see if I can split this into two separate PRs to increase the confidence in the merge.