fix(lodash): Remove dependency on lodash #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
17
to
18
| const pointsStringFromPoints = (points: [number, number][]): string => | ||
| _.reduce(points, (result: string, nextPoint: [number, number]) => `${result} ${nextPoint[0]},${nextPoint[1]}`, ''); | ||
| points?.reduce((result: string, nextPoint: [number, number]) => `${result} ${nextPoint[0]},${nextPoint[1]}`, '') ?? ''; |
There was a problem hiding this comment.
Are types not strict enough to know if points is potentially undefined?
If they are, then we don't need points?. it can simply be points.
Looks like getConnectorBoundingBox has a bad return type and we cannot rely on types :( Please address that return type.
| @@ -55,7 +54,7 @@ const DefaultConnectorTerminal: React.FunctionComponent<EdgeConnectorArrowProps> | |||
| return null; | |||
| } | |||
| const bendPoints = edge.getBendpoints(); | |||
| const startPoint = isTarget ? _.last(bendPoints) || edge.getStartPoint() : _.head(bendPoints) || edge.getEndPoint(); | |||
| const startPoint = isTarget ? bendPoints?.[bendPoints.length - 1] || edge.getStartPoint() : bendPoints?.[0] || edge.getEndPoint(); | |||
There was a problem hiding this comment.
Avoid unnecessary ?.
Suggested change
| const startPoint = isTarget ? bendPoints?.[bendPoints.length - 1] || edge.getStartPoint() : bendPoints?.[0] || edge.getEndPoint(); | |
| const startPoint = isTarget ? bendPoints.[bendPoints.length - 1] || edge.getStartPoint() : bendPoints.[0] || edge.getEndPoint(); |
| @@ -54,19 +53,27 @@ export function computeLabelLocation(points: PointWithSize[]): PointWithSize { | |||
| let lowPoints: PointWithSize[]; | |||
| const threshold = 5; | |||
|
|
|||
| _.forEach(points, p => { | |||
| points?.forEach(p => { | |||
There was a problem hiding this comment.
Suggested change
| points?.forEach(p => { | |
| points.forEach(p => { |
| @@ -60,7 +59,7 @@ export default abstract class BaseElement<E extends ElementModel = ElementModel, | |||
| controller: observable.ref, | |||
| label: observable, | |||
| style: observable, | |||
| ordering: computed({ equals: _.isEqual }) | |||
| ordering: computed({ equals: (a, b) => JSON.stringify(a || {}) === JSON.stringify(b || {}) }) | |||
There was a problem hiding this comment.
This one concerns me a bit.
ordering is an array of numbers. Can we make a specific comparison function.
| layoutNode = _.find(nodes, { id: node.getChildren()[0].getId() }); | ||
| let layoutNode = nodes.find(n => n.id === node.getId()); | ||
| if (!layoutNode && node.getNodes().length) { | ||
| layoutNode = nodes.find(n => n.id === node.getChildren()[0].getId()); |
There was a problem hiding this comment.
IIRC for mobx performance, you'll want to cache the id instead of traversing the observables.
Suggested change
| layoutNode = nodes.find(n => n.id === node.getChildren()[0].getId()); | |
| const id = node.getChildren()[0].getId(); | |
| layoutNode = nodes.find(n => n.id === id); |
| @@ -42,7 +41,7 @@ export class DagreLayout extends BaseLayout implements Layout { | |||
| } | |||
|
|
|||
| protected updateEdgeBendpoints(edges: DagreLink[]): void { | |||
| _.forEach(edges, edge => { | |||
| edges?.forEach(edge => { | |||
There was a problem hiding this comment.
Can this be
Suggested change
| edges?.forEach(edge => { | |
| edges.forEach(edge => { |
|
|
||
| if (!this.dagreOptions.ignoreGroups) { | ||
| _.forEach(this.groups, group => { | ||
| this.groups?.forEach(group => { |
There was a problem hiding this comment.
Can this be:
Suggested change
| this.groups?.forEach(group => { | |
| this.groups.forEach(group => { |
| @@ -88,7 +86,7 @@ const createAggregateEdges = ( | |||
| return newEdges; | |||
| }, | |||
| [] as EdgeModel[] | |||
| ); | |||
| ) ?? []; | |||
There was a problem hiding this comment.
I don't think it's possible for the return value to be undefined here.
| import { GraphElement, Node, isNode, isGraph, NodeStyle } from '../types'; | ||
|
|
||
| const groupNodeElements = (nodes: GraphElement[]): Node[] => { | ||
| if (!_.size(nodes)) { | ||
| if (!nodes?.length) { |
There was a problem hiding this comment.
Can this be:
Suggested change
| if (!nodes?.length) { | |
| if (!nodes.length) { |
| } | ||
| ); | ||
| } | ||
| const children: GraphElement[] = nodeElements.getChildren()?.filter(e => isNode(e)); |
There was a problem hiding this comment.
I don't think children can be undefined here.
jeff-phillips-18
force-pushed
the
rm-lodash
branch
from
fd920f7 to
6beecab
Compare
jeff-phillips-18
force-pushed
the
rm-lodash
branch
from
6beecab to
4214194
Compare
jenny-s51
approved these changes
Feb 15, 2024
jeff-phillips-18
force-pushed
the
rm-lodash
branch
from
4214194 to
b0c87aa
Compare
|
🎉 This PR is included in version 5.3.0-prerelease.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #128
Description
Removes dependency on lodash
Type of change
/cc @christianvogt