ref: rename functions #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename DecodeBytes to DecodeAll rename Node.String to Node.Base64 Currently we have DecodeSingle and DecodeBytes, but it ambiguous to users that the DecodeBytes is actually DecodeAll, and DecodeSingle can also decode 'bytes'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename DecodeBytes to DecodeAll
rename Node.String to Node.Base64
Currently we have DecodeSingle and
DecodeBytes, but it ambiguous to users
that the DecodeBytes is actually DecodeAll,
and DecodeSingle can also decode 'bytes'.
Summary
Describe the changes and fixes, or link to an existing issue.
Checklist
// nolintcomments to the code to fix linter issues.