Code

Main keystore#2

Code

Draft

peteralfonsi wants to merge 18 commits intomainpeteralfonsi/OpenSearch:mainfrom main-keystorepeteralfonsi/OpenSearch:main-keystoreCopy head branch name to clipboard

+1,213-1

Commits

Commits on Sep 22, 2023

• Pasted all changes into new branch off of main

  

  Peter Alfonsi

  committed
  62508dc

• updated SHAs, did spotless check, etc

  

  Peter Alfonsi

  committed
  5cdaf85

• Adding implementations of IntKeyLookupStore.

  Show description for 7f5ade7
  

  Peter Alfonsi

  committed
  7f5ade7

Commits on Sep 25, 2023

• Removed references to quip

  

  Peter Alfonsi

  committed
  bafda1e

• Addressed draft PR comments besides making interface generic (removed unneeded functions, added clear(), changed MB to bytes, misc renamings)

  

  Peter Alfonsi

  committed
  a4cf019

• Moved RBM memory size estimation logic into its own class to prepare for an RBM-only store

  

  Peter Alfonsi

  committed
  6ef2962

• Added and tested new implementing class which only uses an RBM internally

  

  Peter Alfonsi

  committed
  776f3ca

• Added and tested new implementing class which uses only an RBM + keeps track of collided values, see comment for justification for code reuse

  

  Peter Alfonsi

  committed
  2d19d4f

Commits on Sep 26, 2023

• Made interface generic rather than int only

  

  Peter Alfonsi

  committed
  75000f9

Commits on Sep 29, 2023

• Updated + simplified RBM memory size estimator based on new measurements

  

  Peter Alfonsi

  committed
  970f716

• Removed debug functions accidentally added to last commit

  

  Peter Alfonsi

  committed
  85f1ed2

Commits on Oct 2, 2023

• Addressed misc second round comments

  

  Peter Alfonsi

  committed
  f0a62e8

• Addressed misc second round comments

  

  Peter Alfonsi

  committed
  c62bce6

• Merge branch 'main-keystore' of https://github.com/peteralfonsi/OpenSearch into main-keystore

  

  Peter Alfonsi

  committed
  911b130

• Removed unneeded import

  

  Peter Alfonsi

  committed
  e57f35d

• Removed all implementations except RemovableRBMIntKeyLookupStore, which is renamed as RBMIntKeyLookupStore

  

  Peter Alfonsi

  committed
  230194a

Commits on Oct 4, 2023

• tweaked memory size estimator again

  

  Peter Alfonsi

  committed
  75be197

Commits on Oct 23, 2023

• Removed forceRemove and guaranteesFalseNegatives

  

  Peter Alfonsi

  committed
  4abf6ea