-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nextflow Samplesheet: File Selector #879
Draft
ChrisHuynh333
wants to merge
31
commits into
main
Choose a base branch
from
nextflow-samplesheet/file-selector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,016
−207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuynh333
force-pushed
the
nextflow-samplesheet/file-selector
branch
from
January 6, 2025 23:48
e7e565b
to
b02c3fc
Compare
ChrisHuynh333
force-pushed
the
nextflow-samplesheet/file-selector
branch
from
January 7, 2025 22:21
012975c
to
6f9cc82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
This PR is for story
STRY0016505
, which requested the nextflow samplesheet be populated with the most recent uploaded file, and to add the uploaded time of each file to its respective listing.Having filename + created date within the original dropdown selection looked very cumbersome and so, for a better user experience, we decided to create a file selector so more file data could be displayed to the user.
Screenshots or screen recordings
Samplesheet (attachments selection no longer a dropdown)
File Selector:
How to set up and validate locally
Test selecting paired-end files:
fastq_1
orfastq_2
fields, click the file to open the file selector.Test selecting single-end files, default paired-end selection and
No file
selection:fastq_1
field, and verify all the uploaded attachments are included, and that there is noNo file
option (sincefastq_1
is required).fastq_1
field updates with the selection andfastq_2
remains unchanged.fastq_2
field, and verify none of the uploaded attachments are included, and that there is aNo file
option. Select theNo file
option and verify thefastq_2
field was updated accordinglyfastq_1
contains the selected attachment andfastq_2
contains no attachment)Test samplesheet validation of selected files and file selector empty state:
fastq_1
andfastq_2
attachment fields have no file selected.fastq_1
field is highlighted in red, asfastq_2
is not required.fastq_1
orfastq_2
file field. Verify ano attachments
message within the file selector, with no submit button.Test file selector filtering:
1 Selected a seeded sample and launch a workflow (any version)
2. Click either the
fastq_1
orfastq_2
attachment fields.3. Verify
reference.fasta
is not displayed as it's not afastq
file.PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.