feat: add order to pack upg supported targets #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 12 | 0 | 0.04s | |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0.11s | |
| ✅ JSON | eslint-plugin-jsonc | 8 | 0 | 0 | 4.06s |
| ✅ JSON | prettier | 8 | 0 | 0 | 0.5s |
| markdownlint | 7 | 1 | 11 | 1.39s | |
| markdown-link-check | 7 | 1 | 56.45s | ||
| ✅ MARKDOWN | markdown-table-formatter | 7 | 1 | 0 | 0.34s |
| lychee | 126 | 1 | 2.87s | ||
| prettier | 21 | 0 | 1 | 1.08s | |
| ✅ YAML | v8r | 21 | 0 | 8.1s | |
| ✅ YAML | yamllint | 21 | 0 | 0.32s |
See detailed report in MegaLinter reports
MegaLinter is graciously provided by
oguzcanoguz
reviewed
Jun 26, 2023
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
|
Update after discussion: keep the order option, but make it an infra::Optional to remove the '0' special case. Please add some details to the issue description on how to use the feature. |
rjaegers
reviewed
Jun 27, 2023
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
rjaegers
reviewed
Jun 27, 2023
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
rjaegers
reviewed
Jun 27, 2023
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.hpp
Outdated
Show resolved
Hide resolved
rjaegers
reviewed
Jun 27, 2023
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
oguzcanoguz
approved these changes
Jul 7, 2023
…https://github.com/philips-software/amp-embedded-infra-lib into feature/add_order_for_pack_builder_supported_targets
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
oguzcanoguz
approved these changes
Jul 11, 2023
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
* fix: added workaround by replacing CMAKE_C_COMPILER_ID with CMAKE_C_SIMULATE_ID when configuring mbedtls * chore: reworked comment and removed references to xwin
Bumps [Namchee/conventional-pr](https://github.com/namchee/conventional-pr) from 0.14.0 to 0.14.1. - [Release notes](https://github.com/namchee/conventional-pr/releases) - [Commits](Namchee/conventional-pr@5d1221f...cc86d48) --- updated-dependencies: - dependency-name: Namchee/conventional-pr dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.0 to 2.3.1. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@483ef80...0864cf1) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.3 to 2.22.4. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@0116bc2...49abf0b) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…_ECHO_COMPILERS is set (#445) * build: only build and install protobuf echo compilers when EMIL_BUILD_ECHO_COMPILERS is set * protobuf/protoc_echo_plugin*/CMakeLists: Fix emil_build_for statement * Install export file, but only whene EMIL_BUILD_ECHO_COMPILERS
Bumps [oxsecurity/megalinter](https://github.com/oxsecurity/megalinter) from 7.4.0 to 7.5.0. - [Release notes](https://github.com/oxsecurity/megalinter/releases) - [Changelog](https://github.com/oxsecurity/megalinter/blob/main/CHANGELOG.md) - [Commits](oxsecurity/megalinter@a87b287...b48455a) --- updated-dependencies: - dependency-name: oxsecurity/megalinter dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.4 to 2.22.5. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@49abf0b...74483a3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Namchee/conventional-pr](https://github.com/namchee/conventional-pr) from 0.14.1 to 0.15.1. - [Release notes](https://github.com/namchee/conventional-pr/releases) - [Commits](Namchee/conventional-pr@cc86d48...93f5107) --- updated-dependencies: - dependency-name: Namchee/conventional-pr dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… 1.8.0 (#449) build(deps): bump carlosperate/arm-none-eabi-gcc-action Bumps [carlosperate/arm-none-eabi-gcc-action](https://github.com/carlosperate/arm-none-eabi-gcc-action) from 1.7.1 to 1.8.0. - [Release notes](https://github.com/carlosperate/arm-none-eabi-gcc-action/releases) - [Changelog](https://github.com/carlosperate/arm-none-eabi-gcc-action/blob/main/CHANGELOG.md) - [Commits](carlosperate/arm-none-eabi-gcc-action@6a221d7...e9cd61b) --- updated-dependencies: - dependency-name: carlosperate/arm-none-eabi-gcc-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp
Outdated
Show resolved
Hide resolved
richardapeters
approved these changes
Nov 6, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Richard Peters <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
magi-arun
deleted the
feature/add_order_for_pack_builder_supported_targets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add order option to add the supported targets in the specified order for pack builder. Pack builder uses the order option when the
targets in the upgrade pack are to be added in particular sequence. Multiple targets with similar sequence can be of the same order.