Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve hal::Can::Id #786

Merged
merged 2 commits into from
Dec 11, 2024
Merged

feat: improve hal::Can::Id #786

merged 2 commits into from
Dec 11, 2024

Conversation

fabiangottstein
Copy link
Contributor

This PR makes hal::Can::Id creation constexpr and adds defaulted equality operators.
C++ 20 is enabled to make use of default equality operators and is already enabled in amp-hal-st.

@fabiangottstein fabiangottstein requested a review from a team as a code owner December 10, 2024 14:44
Copy link
Contributor

github-actions bot commented Dec 10, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor

github-actions bot commented Dec 10, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 12 0 0.07s
✅ CPP clang-format 998 3 0 6.89s
✅ DOCKERFILE hadolint 2 0 0.15s
✅ JSON jsonlint 9 0 0.19s
✅ JSON prettier 9 0 0 0.57s
⚠️ MARKDOWN markdownlint 6 0 4 1.34s
⚠️ MARKDOWN markdown-link-check 6 1 88.31s
✅ MARKDOWN markdown-table-formatter 6 0 0 0.16s
✅ REPOSITORY checkov yes no 19.22s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 9.28s
✅ REPOSITORY ls-lint yes no 0.06s
✅ REPOSITORY secretlint yes no 5.89s
✅ REPOSITORY trivy yes no 5.93s
✅ REPOSITORY trivy-sbom yes no 0.1s
✅ REPOSITORY trufflehog yes no 3.52s
⚠️ SPELL lychee 140 2 3.52s
⚠️ YAML prettier 23 1 1 1.08s
✅ YAML v8r 23 0 9.28s
✅ YAML yamllint 23 0 0.44s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

hal/interfaces/Can.hpp Show resolved Hide resolved
@fabiangottstein fabiangottstein added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 50860b1 Dec 11, 2024
35 checks passed
@fabiangottstein fabiangottstein deleted the can-id branch December 11, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants