Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add measure of traffic light modification level #199

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Grufoony
Copy link
Collaborator

Add a function which returns a measure of the modification level of a traffic light with respect to the initial state.
We can start from @vero-dav-vero implementation and make it more general.

@Grufoony Grufoony added addition Adding a new feature priority::low Low priority stuff labels Oct 26, 2024
@Grufoony Grufoony self-assigned this Oct 26, 2024
@@ -319,6 +333,18 @@
}
}
m_delay = std::move(delay);
if (delay.first < 5 || delay.second < 5) {

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 12.1 rule Note

MISRA 12.1 rule
m_modTime = 2;
} else if (std::abs(delay.first - delay.second) < 10) {
m_modTime = 0;
} else if ((std::abs(delay.first - delay.second) > 10 ||

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 12.1 rule Note

MISRA 12.1 rule
m_modTime = 0;
} else if ((std::abs(delay.first - delay.second) > 10 ||
std::abs(delay.first - delay.second) == 10) &&
(std::abs(delay.first - delay.second) < 40 ||

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 12.1 rule Note

MISRA 12.1 rule
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 94.73%. Comparing base (ef69f61) to head (327523c).

Files with missing lines Patch % Lines
src/dsm/headers/Node.hpp 42.85% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
- Coverage   94.77%   94.73%   -0.04%     
==========================================
  Files          17       17              
  Lines        3004     3345     +341     
  Branches      294      299       +5     
==========================================
+ Hits         2847     3169     +322     
- Misses        157      176      +19     
Flag Coverage Δ
unittests 94.73% <42.85%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition Adding a new feature priority::low Low priority stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant