Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing specs #21

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fixing specs #21

merged 1 commit into from
Jul 16, 2024

Conversation

BMayhew
Copy link
Contributor

@BMayhew BMayhew commented Jul 16, 2024

Summary by CodeRabbit

  • New Feature: Updated image URLs to local files for room creation, enhancing performance.
  • Enhancement: Changed logo format to .jpg for Shady Meadows B&B branding.
  • Style: Switched test case image URL from absolute to relative path for better portability.

Remember, changing a logo from .png to .jpg is like converting a GIF into a still image—less moving parts!

Copy link

github-actions bot commented Jul 16, 2024

Image description CodeRabbit

Walkthrough

The changes include updating image URLs, transitioning from .png to .jpg format for logos, and refining room descriptions. A Playwright config tweak for retries was also made.

Changes

Files Summary
bruno/branding/PUT branding.bru, lib/helpers/branding.ts Updated logoUrl from .png to .jpg for Shady Meadows B&B with description update.
lib/datafactory/room.ts, tests/room/room.get.spec.ts Modified image URLs in room.ts functions to local images, changed test case image URL path to relative in room.get.spec.ts. Updated room description text.
playwright.config.ts Added retries: 2 configuration option in Playwright config file.

Poem

🐇 Hoppy changes in the code,
From PNG to JPG it strode.
Room descriptions now refined,
Playwright config, a tweak so kind.
Bugs beware, we're on a roll,
CodeRabbit's here to make you whole! 🥕🌟


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between a2c64e1 and 853abad commits.
Files selected (5)
  • bruno/branding/PUT branding.bru (1)
  • lib/datafactory/room.ts (2)
  • lib/helpers/branding.ts (1)
  • playwright.config.ts (1)
  • tests/room/room.get.spec.ts (1)
Files skipped from review due to trivial changes (4)
  • bruno/branding/PUT branding.bru
  • lib/datafactory/room.ts
  • lib/helpers/branding.ts
  • playwright.config.ts
Review comments generated (1)
  • Review: 1
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@@ -42,7 +42,7 @@ test.describe("room/ GET requests @room", async () => {
expect(firstRoom.roomid).toBe(1);
expect(firstRoom.roomName).toBe("101");
expect(firstRoom.type).toBe("single");
expect(firstRoom.image).toBe("https://www.mwtestconsultancy.co.uk/img/testim/room2.jpg");
expect(firstRoom.image).toBe("/images/room2.jpg");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Changing image URLs from absolute to relative paths can cause issues with loading resources correctly, especially if the context changes. Consider the implications of this change on the application's functionality and scalability.

-    expect(firstRoom.image).toBe("https://www.mwtestconsultancy.co.uk/img/testim/room2.jpg");
+    expect(firstRoom.image).toBe("/images/room2.jpg");

Copy link

currents-bot bot commented Jul 16, 2024

Currents Tests: Playwright API Demo tests passed after 29s

🟢 52 · 🔴 0 · ⚪️ 0

View Run Details

Run Details

  • Project: Playwright API Demo

  • Groups: 3

  • Framework: Playwright

  • Run Status: Passed

  • Commit: 86e1db7

  • Spec files: 20

  • Overall tests: 52

  • Duration: 29s

  • Parallelization: 3

Groups

GroupId Results Spec Files Progress
teardown 🟢 0 · 🔴 0 · ⚪️ 0 0 / 1
api-checks 🟢 51 · 🔴 0 · ⚪️ 0 18 / 18
setup 🟢 1 · 🔴 0 · ⚪️ 0 1 / 1


This message was posted automatically by currents.dev | Integration Settings

@BMayhew BMayhew merged commit e919252 into main Jul 16, 2024
6 checks passed
@BMayhew BMayhew deleted the bm/fixing-api-specs branch July 16, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant