-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing specs #21
fixing specs #21
Conversation
WalkthroughThe changes include updating image URLs, transitioning from Changes
Poem
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files selected (5)
- bruno/branding/PUT branding.bru (1)
- lib/datafactory/room.ts (2)
- lib/helpers/branding.ts (1)
- playwright.config.ts (1)
- tests/room/room.get.spec.ts (1)
Files skipped from review due to trivial changes (4)
- bruno/branding/PUT branding.bru
- lib/datafactory/room.ts
- lib/helpers/branding.ts
- playwright.config.ts
Review comments generated (1)
- Review: 1
- LGTM: 0
Tips
Chat with CodeRabbit Bot (@coderabbitai
)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitai
in a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignore
anywhere in the PR description to pause further reviews from the bot.
@@ -42,7 +42,7 @@ test.describe("room/ GET requests @room", async () => { | |||
expect(firstRoom.roomid).toBe(1); | |||
expect(firstRoom.roomName).toBe("101"); | |||
expect(firstRoom.type).toBe("single"); | |||
expect(firstRoom.image).toBe("https://www.mwtestconsultancy.co.uk/img/testim/room2.jpg"); | |||
expect(firstRoom.image).toBe("/images/room2.jpg"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing image URLs from absolute to relative paths can cause issues with loading resources correctly, especially if the context changes. Consider the implications of this change on the application's functionality and scalability.
- expect(firstRoom.image).toBe("https://www.mwtestconsultancy.co.uk/img/testim/room2.jpg");
+ expect(firstRoom.image).toBe("/images/room2.jpg");
Currents Tests: Playwright API Demo tests passed after 29s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
Summary by CodeRabbit
.jpg
for Shady Meadows B&B branding.Remember, changing a logo from
.png
to.jpg
is like converting a GIF into a still image—less moving parts!