Fix(Notification): better fix for double notification #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonebuzz
force-pushed
the
fix_notification
branch
2 times, most recently
from
441dde5 to
4c315cc
Compare
stonebuzz
force-pushed
the
fix_notification
branch
from
4c315cc to
d114149
Compare
Rom1-B
reviewed
Dec 27, 2024
| @@ -69,29 +69,33 @@ | |||
| if ($_SESSION['plugins']['escalade']['config']['ticket_last_status'] != -1) { | |||
| $_form_object['status'] = $_SESSION['plugins']['escalade']['config']['ticket_last_status']; | |||
| } | |||
| $updates_ticket = new Ticket(); | |||
| if ( | |||
There was a problem hiding this comment.
Without the if, the task will be created even if adding the group fails?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Better fix for https://github.com/pluginsGLPI/escalade/pull/253/files
Refactor code
Add
group_Ticketinstead of updateTicket(and get more than one notificationScreenshots (if appropriate):