Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): show only npm install #2325

Merged
merged 2 commits into from
Jan 10, 2024
Merged

chore(docs): show only npm install #2325

merged 2 commits into from
Jan 10, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jan 4, 2024

It's 2024, and we can't list all npm alternatives. Let's simplify.

@vercel Vercel
Copy link

vercel bot commented Jan 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 8:59am

@dai-shi dai-shi requested a review from sandren January 4, 2024 08:00
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 4, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3c34bfb:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

dai-shi
dai-shi commented Jan 4, 2024
View reviewed changes
docs/extensions/immer.mdx
@@ -109,6 +107,8 @@ const Controls = () => {

It would be better if you don't use `withImmer` and `atomWithImmer` with `useImmerAtom` because they provide the immer-like `writeFunction` and we don't need to create a new one.

You can use `useSetImmerAtom` if you need only the setter part of `useImmerAtom`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New feature in jotai-immer v0.3.0.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

Size Change: 0 B

Total Size: 68.7 kB

ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 907 B
dist/babel/plugin-react-refresh.js 1.14 kB
dist/babel/preset.js 1.38 kB
dist/index.js 242 B
dist/react.js 1.06 kB
dist/react/utils.js 1.26 kB
dist/system/babel/plugin-debug-label.development.js 1.09 kB
dist/system/babel/plugin-debug-label.production.js 757 B
dist/system/babel/plugin-react-refresh.development.js 1.29 kB
dist/system/babel/plugin-react-refresh.production.js 929 B
dist/system/babel/preset.development.js 1.56 kB
dist/system/babel/preset.production.js 1.13 kB
dist/system/index.development.js 236 B
dist/system/index.production.js 167 B
dist/system/react.development.js 1.18 kB
dist/system/react.production.js 711 B
dist/system/react/utils.development.js 722 B
dist/system/react/utils.production.js 461 B
dist/system/utils.development.js 241 B
dist/system/utils.production.js 175 B
dist/system/vanilla.development.js 4.04 kB
dist/system/vanilla.production.js 2 kB
dist/system/vanilla/utils.development.js 4.55 kB
dist/system/vanilla/utils.production.js 2.79 kB
dist/umd/babel/plugin-debug-label.development.js 1.06 kB
dist/umd/babel/plugin-debug-label.production.js 845 B
dist/umd/babel/plugin-react-refresh.development.js 1.28 kB
dist/umd/babel/plugin-react-refresh.production.js 1.01 kB
dist/umd/babel/preset.development.js 1.53 kB
dist/umd/babel/preset.production.js 1.24 kB
dist/umd/index.development.js 381 B
dist/umd/index.production.js 329 B
dist/umd/react.development.js 1.18 kB
dist/umd/react.production.js 785 B
dist/umd/react/utils.development.js 1.43 kB
dist/umd/react/utils.production.js 1.03 kB
dist/umd/utils.development.js 398 B
dist/umd/utils.production.js 343 B
dist/umd/vanilla.development.js 4.83 kB
dist/umd/vanilla.production.js 2.17 kB
dist/umd/vanilla/utils.development.js 5.34 kB
dist/umd/vanilla/utils.production.js 3.3 kB
dist/utils.js 246 B
dist/vanilla.js 4.75 kB
dist/vanilla/utils.js 5.21 kB

compressed-size-action

sandren
sandren reviewed Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@sandren sandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everyone should understand that dependencies can be installed "with your preferred package manager" so I think those lines can be omitted. 🙂

@dai-shi dai-shi requested a review from sandren January 5, 2024 08:59
himself65
himself65 reviewed Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some document support select from multiple package managers as preferences.

This might be another idea but spends extra work

https://nextra.site/docs/guide/built-ins/tabs

@dai-shi
Copy link
Member Author

dai-shi commented Jan 9, 2024

Well, that's different from my motivation. (But I'll consider such alternatives if this confuses people too much.)

sandren
sandren approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@sandren sandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙂

@sandren sandren merged commit b5ac43a into main Jan 10, 2024
33 checks passed
@dai-shi dai-shi deleted the chore/docs/show-npm-usage branch January 10, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 left review comments

@sandren sandren sandren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dai-shi @himself65 @sandren