Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new starter example #2870

Merged
merged 8 commits into from
Dec 28, 2024
Merged

feat: new starter example #2870

merged 8 commits into from
Dec 28, 2024

Conversation

leweyse
Copy link
Contributor

@leweyse leweyse commented Dec 17, 2024

Summary

New starter example

Check List

  • pnpm run prettier for formatting code and docs

image

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 2:42pm

Copy link

codesandbox-ci bot commented Dec 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it. It generally looks good.
And I noticed several issues in existing examples.

examples/starter/README.md Outdated Show resolved Hide resolved
examples/starter/package.json Outdated Show resolved Hide resolved
examples/starter/src/vite-env.d.ts Show resolved Hide resolved
Copy link

pkg-pr-new bot commented Dec 18, 2024

Open in Stackblitz

More templates

npm i https://pkg.pr.new/jotai@2870

commit: f8608d7

Copy link

github-actions bot commented Dec 18, 2024

LiveCodes Preview in LiveCodes

Latest commit: f8608d7
Last updated: Dec 27, 2024 2:42pm (UTC)

Playground Link
React demo https://livecodes.io?x=id/FRQRXQEW7

See documentations for usage instructions.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change requests. please make valtio and zustand examples to follow this.

examples/starter/README.md Outdated Show resolved Hide resolved
examples/starter/README.md Outdated Show resolved Hide resolved
examples/starter/index.html Outdated Show resolved Hide resolved
examples/starter/src/app.tsx Outdated Show resolved Hide resolved
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for your contribution!

@dai-shi dai-shi merged commit 65a8500 into pmndrs:main Dec 28, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants