alternate implementation for #2801 #2888
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
Size Change: +553 B (+0.6%) Total Size: 92.6 kB
ℹ️ View Unchanged
|
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/HJSX59JW3 |
See documentations for usage instructions.
dmaskasky
reviewed
Dec 26, 2024
| @@ -1,3 +1,5 @@ | |||
| import type { INTERNAL_PrdStore as Store } from './store' | |||
There was a problem hiding this comment.
Suggested change
| import type { INTERNAL_PrdStore as Store } from './store' | |
| import type { PrdOrDevStore as Store } from './store' |
There was a problem hiding this comment.
That's correct for the current implementation, but as I plan to remove DevStore by default in the future, this limits more. Maybe I did wrong with S extends Store too.
dmaskasky
reviewed
Dec 26, 2024
src/vanilla/store.ts
Outdated
| @@ -260,6 +264,7 @@ type StoreArgs = readonly [ | |||
| atom: WritableAtom<Value, Args, Result>, | |||
| setAtom: (...args: Args) => Result, | |||
| ) => OnUnmount | void, | |||
| atomOnInit: <Value>(atom: Atom<Value>, store: Store) => void, | |||
There was a problem hiding this comment.
Should Init come before Mount in StoreArgs?
dmaskasky
reviewed
Dec 26, 2024
src/vanilla/store.ts
Outdated
Comment on lines
251
to
254
| setAtomState: <Value>( | ||
| atom: Atom<Value>, | ||
| atomState: AtomState<Value>, | ||
| ) => AtomState<Value>, |
There was a problem hiding this comment.
though, returning a (possibly modified) atomState is not very intuitive.
There was a problem hiding this comment.
hmm, maybe this could help, though its a little pedantic
setAtomState: <Value, AS extends AtomState<Value>>(
atom: Atom<Value>,
atomState: AS,
) => AS,There was a problem hiding this comment.
Good idea. The arg must be original one.
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternate implementation for #2801
Goals:
Remaining:
FIXMEcomments in effect.test.ts