Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: following up #2912 #2915

Merged
merged 1 commit into from
Jan 7, 2025
Merged

refactor: following up #2912 #2915

merged 1 commit into from
Jan 7, 2025

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jan 7, 2025

I wasn't able to notice it in #2912.

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 0:48am

Copy link

codesandbox-ci bot commented Jan 7, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Jan 7, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/jotai@2915

commit: fc1227a

Comment on lines +61 to +63
p: unknown,
): p is PromiseLike<unknown> & { onCancel?: (fn: CancelHandler) => void } =>
typeof (p as any)?.then === 'function'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A refactor to follow #2907.

Copy link

github-actions bot commented Jan 7, 2025

Size Change: +1 B (0%)

Total Size: 92.1 kB

Filename Size Change
./dist/esm/vanilla.mjs 4.22 kB +2 B (+0.05%)
./dist/system/vanilla.development.js 4.31 kB -1 B (-0.02%)
./dist/system/vanilla.production.js 2.17 kB -3 B (-0.14%)
./dist/umd/vanilla.development.js 5.68 kB +3 B (+0.05%)
./dist/umd/vanilla.production.js 2.86 kB -3 B (-0.1%)
./dist/vanilla.js 5.57 kB +3 B (+0.05%)
ℹ️ View Unchanged
Filename Size
./dist/babel/plugin-debug-label.js 932 B
./dist/babel/plugin-react-refresh.js 1.14 kB
./dist/babel/preset.js 1.41 kB
./dist/esm/babel/plugin-debug-label.mjs 1 kB
./dist/esm/babel/plugin-react-refresh.mjs 1.19 kB
./dist/esm/babel/preset.mjs 1.49 kB
./dist/esm/index.mjs 62 B
./dist/esm/react.mjs 1.4 kB
./dist/esm/react/utils.mjs 746 B
./dist/esm/utils.mjs 67 B
./dist/esm/vanilla/utils.mjs 5.04 kB
./dist/index.js 242 B
./dist/react.js 1.44 kB
./dist/react/utils.js 1.39 kB
./dist/system/babel/plugin-debug-label.development.js 1.1 kB
./dist/system/babel/plugin-debug-label.production.js 775 B
./dist/system/babel/plugin-react-refresh.development.js 1.29 kB
./dist/system/babel/plugin-react-refresh.production.js 928 B
./dist/system/babel/preset.development.js 1.59 kB
./dist/system/babel/preset.production.js 1.14 kB
./dist/system/index.development.js 252 B
./dist/system/index.production.js 183 B
./dist/system/react.development.js 1.56 kB
./dist/system/react.production.js 864 B
./dist/system/react/utils.development.js 860 B
./dist/system/react/utils.production.js 462 B
./dist/system/utils.development.js 257 B
./dist/system/utils.production.js 187 B
./dist/system/vanilla/utils.development.js 5.25 kB
./dist/system/vanilla/utils.production.js 3.14 kB
./dist/umd/babel/plugin-debug-label.development.js 1.08 kB
./dist/umd/babel/plugin-debug-label.production.js 852 B
./dist/umd/babel/plugin-react-refresh.development.js 1.27 kB
./dist/umd/babel/plugin-react-refresh.production.js 1 kB
./dist/umd/babel/preset.development.js 1.54 kB
./dist/umd/babel/preset.production.js 1.22 kB
./dist/umd/index.development.js 383 B
./dist/umd/index.production.js 328 B
./dist/umd/react.development.js 1.57 kB
./dist/umd/react.production.js 936 B
./dist/umd/react/utils.development.js 1.53 kB
./dist/umd/react/utils.production.js 1.01 kB
./dist/umd/utils.development.js 399 B
./dist/umd/utils.production.js 342 B
./dist/umd/vanilla/utils.development.js 6.24 kB
./dist/umd/vanilla/utils.production.js 3.78 kB
./dist/utils.js 247 B
./dist/vanilla/utils.js 6.1 kB

compressed-size-action

@dai-shi dai-shi marked this pull request as ready for review January 7, 2025 12:49
Copy link

github-actions bot commented Jan 7, 2025

LiveCodes Preview in LiveCodes

Latest commit: fc1227a
Last updated: Jan 7, 2025 12:48pm (UTC)

Playground Link
React demo https://livecodes.io?x=id/6ED4T4MFV

See documentations for usage instructions.

@dai-shi dai-shi merged commit 20cc2a8 into main Jan 7, 2025
43 checks passed
@dai-shi dai-shi deleted the refactor/follow-up-2912 branch January 7, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant