You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
EffectComposer.tsx sets the size of the renderer based on the value of size from useThree(). When using the View component from react-three-fiber, that size value doesn't necessarily track the size of the underlying canvas which results in the view being improperly offset.
It's not entirely clear that the fix should be in this library, but it seemed like the cleanest to me.
EffectComposer.tsx sets the size of the renderer based on the value of
size
fromuseThree()
. When using the View component fromreact-three-fiber
, thatsize
value doesn't necessarily track the size of the underlying canvas which results in the view being improperly offset.It's not entirely clear that the fix should be in this library, but it seemed like the cleanest to me.
I'm using this fix: master...closedcontour:react-postprocessing:effect-composer-sizing. I'm happy to open a PR if you'd like. Thanks.
The text was updated successfully, but these errors were encountered: