Extend Texture Effect to support opacity #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the <Texture /> Effect to support opacity
fix the way we check for availability of opacity. * edge case: opacity==0 would be considered absent in previous method
src/effects/Texture.tsx
Outdated
Comment on lines
25
to
31
| const effect = useMemo(() => { | ||
| let tEffect = new TextureEffect({ ...props, texture: t || texture }); | ||
| if (typeof opacity === "number") { | ||
| tEffect.blendMode.opacity.value = opacity; | ||
| } | ||
| return tEffect; | ||
| }, [props, t, texture, opacity]) |
There was a problem hiding this comment.
I'd prefer setting this as a prop instead so we don't recreate the effect and its resources when opacity changes (e.g. <primitive object={effect} blendMode-opacity-value={opacity ?? 1} />).
There was a problem hiding this comment.
Aha, I didn't know about such possibility. I'd implement that way and commit it then
Update the way opacity is applied * instead of recreating an effect every time opacity changes we feed it to the final primitive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the Texture Effect to support a new parameter called
opacity. this parameter is used when creatingTextureEffectto set the opacity ofBlendMode. The idea and practice comes from the example provided frompostproccessinglibrary.the reference: https://github.com/pmndrs/postprocessing/blob/e758f65ef2277d006c9785d8148926bf78235441/demo/src/demos/TextureDemo.js#L194