Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): preserve deprecated XR type annotations #3111

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

CodyJasonBennett
Copy link
Member

Fixes #3110. Mirrors #3062 for XRFrame.

Copy link

codesandbox-ci bot commented Dec 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7c2c8a6:

Sandbox Source
example Configuration

@CodyJasonBennett CodyJasonBennett merged commit 0ad80d0 into master Dec 3, 2023
2 checks passed
@CodyJasonBennett CodyJasonBennett deleted the fix/types-comments-xr branch December 3, 2023 11:40
renovate bot referenced this pull request in simonknittel/sinister-incorporated Dec 20, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) |
[`8.15.10` ->
`8.15.12`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.15.10/8.15.12)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@react-three%2ffiber/8.15.12?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@react-three%2ffiber/8.15.12?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@react-three%2ffiber/8.15.10/8.15.12?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@react-three%2ffiber/8.15.10/8.15.12?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pmndrs/react-three-fiber (@&#8203;react-three/fiber)</summary>

###
[`v8.15.12`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.15.12)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.15.11...v8.15.12)

#### What's Changed

- fix(useLoader): loosen GLTF inference check by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/3105](https://togithub.com/pmndrs/react-three-fiber/pull/3105)
- fix(types): preserve deprecated XR type annotations by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/3111](https://togithub.com/pmndrs/react-three-fiber/pull/3111)

**Full Changelog**:
pmndrs/react-three-fiber@v8.15.11...v8.15.12

###
[`v8.15.11`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.15.11)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.15.10...v8.15.11)

#### What's Changed

- fix(types): update import from three/examples by
[@&#8203;Methuselah96](https://togithub.com/Methuselah96) in
[https://github.com/pmndrs/react-three-fiber/pull/3095](https://togithub.com/pmndrs/react-three-fiber/pull/3095)

#### New Contributors

- [@&#8203;warrenseine](https://togithub.com/warrenseine) made their
first contribution in
[https://github.com/pmndrs/react-three-fiber/pull/3094](https://togithub.com/pmndrs/react-three-fiber/pull/3094)

**Full Changelog**:
pmndrs/react-three-fiber@v8.15.10...v8.15.11

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/simonknittel/sinister-incorporated).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vendor Types For XRFrame Resolving Incorrectly
1 participant