Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): useProxy to avoid re-renders when no props are touched #809

Merged
merged 2 commits into from
Nov 28, 2023
Merged

fix(utils): useProxy to avoid re-renders when no props are touched #809

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6964bd
fix(utils): useProxy to avoid re-renders when no props are touched
dai-shi Nov 5, 2023
e4c8324
Merge branch 'main' into fix/issue-808
dai-shi Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/react/utils/useProxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { useLayoutEffect } from 'react'
import { useSnapshot } from '../../react.ts'

const DUMMY_SYMBOL = Symbol()

/**
* useProxy
*
Expand Down Expand Up @@ -28,8 +30,10 @@ export function useProxy<T extends object>(
): T {
const snapshot = useSnapshot(proxy, options) as T

let isRendering = true
// touch dummy prop so that it doesn't trigger re-renders when no props are touched.
;(snapshot as any)[DUMMY_SYMBOL]

let isRendering = true
useLayoutEffect(() => {
// This is an intentional hack
// eslint-disable-next-line react-hooks/exhaustive-deps
Expand Down
Loading