-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed iterator reactivity in proxyMap and proxySet #988
Conversation
…es directory with the newest version of valtio
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
Size Change: +24 B (+0.18%) Total Size: 13.6 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge later when I prepare the patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!!
happy to be helpful! |
Related Bug Reports or Discussions
#987
Fixes #
#987
Summary
proxyMap and proxySet iterator methods lacked having the epoch version being set when they are used. Added them in and added tests to make sure they work.
Check List
pnpm run prettier
for formatting code and docs