Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed iterator reactivity in proxyMap and proxySet #988

Merged
merged 13 commits into from
Nov 5, 2024
Merged

Fixed iterator reactivity in proxyMap and proxySet #988

merged 13 commits into from
Nov 5, 2024

Conversation

overthemike
Copy link
Collaborator

Related Bug Reports or Discussions

#987
Fixes #
#987

Summary

proxyMap and proxySet iterator methods lacked having the epoch version being set when they are used. Added them in and added tests to make sure they work.

Check List

  • [ x ] pnpm run prettier for formatting code and docs

Copy link

vercel bot commented Nov 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 11:17am

Copy link

codesandbox-ci bot commented Nov 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Nov 3, 2024

Open in Stackblitz

More templates

pnpm add https://pkg.pr.new/valtio@988

commit: 4ab2aae

Copy link

github-actions bot commented Nov 3, 2024

Size Change: +24 B (+0.18%)

Total Size: 13.6 kB

Filename Size Change
./dist/esm/vanilla/utils.mjs 3.15 kB +11 B (+0.35%)
./dist/vanilla/utils.js 3.19 kB +13 B (+0.41%)
ℹ️ View Unchanged
Filename Size
./dist/esm/index.mjs 63 B
./dist/esm/react.mjs 691 B
./dist/esm/react/utils.mjs 257 B
./dist/esm/utils.mjs 68 B
./dist/esm/vanilla.mjs 2.35 kB
./dist/index.js 243 B
./dist/react.js 681 B
./dist/react/utils.js 278 B
./dist/utils.js 248 B
./dist/vanilla.js 2.38 kB

compressed-size-action

@overthemike overthemike marked this pull request as ready for review November 3, 2024 04:43
@overthemike overthemike requested a review from dai-shi November 3, 2024 04:43
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge later when I prepare the patch.

tests/proxyMap.test.tsx Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!!

@overthemike
Copy link
Collaborator Author

happy to be helpful!

@dai-shi dai-shi merged commit 159221e into main Nov 5, 2024
29 checks passed
@dai-shi dai-shi deleted the 987 branch November 5, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants