Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: incorporate eslint-plugin-testing-library and fix reported issues #992

Merged

Conversation

kretajak
Copy link
Contributor

@kretajak kretajak commented Nov 8, 2024

Summary

Testing Library provides Eslint plugin which encourages to use best practices.

Check List

  • pnpm run prettier for formatting code and docs

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 9:46pm

Copy link

codesandbox-ci bot commented Nov 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Nov 8, 2024

Open in Stackblitz

More templates

pnpm add https://pkg.pr.new/valtio@992

commit: 62eb48c

@kretajak kretajak force-pushed the incorporate-eslint-testing-library-plugin branch from 1739e3a to 62eb48c Compare November 8, 2024 21:45
@dai-shi dai-shi merged commit bb8fe84 into pmndrs:main Nov 9, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants