test: add jest-dom matchers and eslint plugin #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
kretajak
force-pushed
the
use-jest-dom-matchers-and-eslint-plugin-jest-dom
branch
from
d016dd4 to
2e0e4e9
Compare
kretajak
force-pushed
the
use-jest-dom-matchers-and-eslint-plugin-jest-dom
branch
from
2e0e4e9 to
c3d6ecd
Compare
kretajak
force-pushed
the
use-jest-dom-matchers-and-eslint-plugin-jest-dom
branch
from
c3d6ecd to
6483f5d
Compare
kretajak
commented
Nov 11, 2024
| @@ -2,7 +2,6 @@ | |||
| "compilerOptions": { | |||
| "target": "esnext", | |||
| "strict": true, | |||
| "lib": ["es2023"], | |||
There was a problem hiding this comment.
This line seems to be problematic with my changes and old TS versions. Zustand supports the same range of TypeScript versions but lacks this line. Maybe it can be safely removed?
There was a problem hiding this comment.
It's added in #930. I think it's related to } catch { change.
If omitting this line goes well, I think it's fine to remove.
There was a problem hiding this comment.
Seems like using "lib": ["dom"] satisfies all TS versions.
kretajak
force-pushed
the
use-jest-dom-matchers-and-eslint-plugin-jest-dom
branch
from
6483f5d to
469a1d8
Compare
1 task
kretajak
force-pushed
the
use-jest-dom-matchers-and-eslint-plugin-jest-dom
branch
from
469a1d8 to
e8a3d02
Compare
kretajak
force-pushed
the
use-jest-dom-matchers-and-eslint-plugin-jest-dom
branch
from
e8a3d02 to
8cc6364
Compare
kretajak
deleted the
use-jest-dom-matchers-and-eslint-plugin-jest-dom
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Library provides nice set of custom matchers that are more declarative and easier to understand. Along with
@testing-library/jest-domthere is an accompanyingeslint-plugin-jest-domwhich enforce using these selectors.Check List
pnpm run prettierfor formatting code and docs