Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cargo): bump derive_more to beta.6 #212

Merged
merged 1 commit into from
Nov 22, 2023
Merged

chore(cargo): bump derive_more to beta.6 #212

merged 1 commit into from
Nov 22, 2023

Conversation

KSXGitHub
Copy link
Contributor

Closes #207

@KSXGitHub KSXGitHub requested review from zkochan and anonrig November 21, 2023 16:13
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (744976d) 87.04% compared to head (7e6051b) 87.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files          57       57           
  Lines        2848     2848           
=======================================
  Hits         2479     2479           
  Misses        369      369           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Micro-Benchmark Results

Linux

group                          main                                   pr
-----                          ----                                   --
tarball/download_dependency    1.02      6.8±0.37ms   641.5 KB/sec    1.00      6.7±0.17ms   651.3 KB/sec

Copy link

Integrated-Benchmark Report (Linux)

Scenario: Frozen Lockfile

Command Mean [ms] Min [ms] Max [ms] Relative
pacquet@HEAD 129.7 ± 11.4 115.5 148.0 1.05 ± 0.11
pacquet@main 123.0 ± 6.9 114.8 141.7 1.00
BENCHMARK_REPORT.json
{
  "results": [
    {
      "command": "pacquet@HEAD",
      "mean": 0.12971105012,
      "stddev": 0.011373780004415067,
      "median": 0.12633392162,
      "user": 0.060843794285714285,
      "system": 0.20279404571428566,
      "min": 0.11554251612000001,
      "max": 0.14795130212,
      "times": [
        0.14795130212,
        0.12433279112000002,
        0.13546257511999998,
        0.11727313112000001,
        0.13983314612,
        0.11707593412000002,
        0.11554251612000001,
        0.14331543012,
        0.12466623012000001,
        0.13546633012,
        0.12800161312,
        0.12439639912000001,
        0.11736401812000001,
        0.14527328512
      ],
      "exit_codes": [
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0
      ]
    },
    {
      "command": "pacquet@main",
      "mean": 0.12302721580749999,
      "stddev": 0.006884955610123173,
      "median": 0.12228114712000002,
      "user": 0.061603080000000005,
      "system": 0.2018263225,
      "min": 0.11481083512000001,
      "max": 0.14167453312,
      "times": [
        0.12358206012000002,
        0.11481083512000001,
        0.12120177112000001,
        0.13072049312,
        0.11503135012000001,
        0.11905671812000002,
        0.11614862012,
        0.14167453312,
        0.11899228412000001,
        0.11903325512000001,
        0.12336052312000001,
        0.12828295911999998,
        0.12573219012,
        0.12600340512,
        0.12621308711999998,
        0.11859136812000001
      ],
      "exit_codes": [
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0
      ]
    }
  ]
}

@zkochan
Copy link
Member

zkochan commented Nov 22, 2023

Why didn't you push to the already existing PR?

@zkochan zkochan merged commit c62a631 into main Nov 22, 2023
13 checks passed
@zkochan zkochan deleted the bump-derive-more branch November 22, 2023 00:22
@KSXGitHub
Copy link
Contributor Author

Why didn't you push to the already existing PR?

No particular reason. I guess it was easier to just edit Cargo.toml directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants