Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: divide pacquet-fs into multiple files #214

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

KSXGitHub
Copy link
Contributor

Another PR requires this refactor. I make this a separate PR for easy diff.

@KSXGitHub KSXGitHub requested review from zkochan and anonrig November 22, 2023 17:09
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (c62a631) 92.65% compared to head (41f6b05) 92.65%.

Files Patch % Lines
crates/fs/src/file_mode.rs 33.33% 6 Missing ⚠️
crates/fs/src/ensure_file.rs 88.46% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage   92.65%   92.65%           
=======================================
  Files          57       59    +2     
  Lines        2847     2847           
=======================================
  Hits         2638     2638           
  Misses        209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Micro-Benchmark Results

Linux

group                          main                                   pr
-----                          ----                                   --
tarball/download_dependency    1.01      6.8±0.34ms   640.7 KB/sec    1.00      6.7±0.15ms   650.0 KB/sec

Copy link

Integrated-Benchmark Report (Linux)

Scenario: Frozen Lockfile

Command Mean [ms] Min [ms] Max [ms] Relative
pacquet@HEAD 128.8 ± 12.2 112.7 149.8 1.04 ± 0.13
pacquet@main 124.1 ± 10.8 109.8 144.8 1.00
BENCHMARK_REPORT.json
{
  "results": [
    {
      "command": "pacquet@HEAD",
      "mean": 0.1287552813657143,
      "stddev": 0.012223158123635705,
      "median": 0.12481295008,
      "user": 0.05480472000000001,
      "system": 0.20804341714285715,
      "min": 0.11265351808,
      "max": 0.14976112608,
      "times": [
        0.14845050208000002,
        0.14341390908,
        0.12753799808,
        0.12661904208,
        0.12299944908,
        0.12929328708,
        0.14976112608,
        0.11619144708000001,
        0.12004258908000001,
        0.11761429508,
        0.12299175608,
        0.14199816208000002,
        0.12300685808,
        0.11265351808
      ],
      "exit_codes": [
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0
      ]
    },
    {
      "command": "pacquet@main",
      "mean": 0.12411295676750002,
      "stddev": 0.010812024404156372,
      "median": 0.12408124708000001,
      "user": 0.05777034500000001,
      "system": 0.20566568500000001,
      "min": 0.10980995408000001,
      "max": 0.14480860308000001,
      "times": [
        0.12382968908,
        0.12611078308,
        0.11321339408,
        0.13218096308000002,
        0.13284036408,
        0.12428732108000001,
        0.13267985408,
        0.12594394108,
        0.10980995408000001,
        0.11923158408000001,
        0.14480860308000001,
        0.11184873208,
        0.11111872708000001,
        0.12387517308000001,
        0.11252745608,
        0.14150076908
      ],
      "exit_codes": [
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0
      ]
    }
  ]
}

@zkochan zkochan merged commit d852b52 into main Nov 28, 2023
12 of 13 checks passed
@zkochan zkochan deleted the refactor-pacquet-fs branch November 28, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants