Changed cosmic::command to cosmic::task, and made cosmic::Task consistent with cosmic::app::Task #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sk to reexport cosmic::app::Task instead of iced::Task
Not exactly sure why, but the wayland feature disables cosmic::app so this is required
wash2
approved these changes
Nov 21, 2024
|
cosmic-comp uses libcosmic but it doesn't need the app module or the winit feature. I think all libcosmic apps should be using the winit feature, so is it a problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the cosmic::command module to cosmic::task ever since the change from Command to Task, and also fixes an inconsistency where cosmic::Task was a re-export of iced::Task while cosmic::app::Task was a different type alias