Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window border corner appearance #732

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Fix window border corner appearance #732

merged 2 commits into from
Nov 26, 2024

Conversation

git-f0x
Copy link
Contributor

@git-f0x git-f0x commented Nov 25, 2024

This removes the background of the header bar and content containers, and moves it to the container wrapping both, in order for the border to be drawn properly.

The second commit matches the spacing of buttons in header bar sections to the designs.

Edit: Apps without content containers but with a header bar won't benefit as much (they do see a slight improvement), but not sure if it's possible to do something about that.
A thing that would enable fixing this (and would be useful for other things), is for the border/border color to be settable per-side, which would enable setting the border in the individual containers, rather than in the wrapping container in app/mod.rs, which could then likely be removed (though not sure about the drawing logic in the corners).
An API for that could be just to have the border color as a Vec, with similar convenience features as e.g. padding (color: Color would be equivalent to color: [Color, Color, Color, Color]).

Should I restrict the value of the radius_s - 1.0 values to have a minimum value of 0 or radius_0, so that if someone sets the radius to 0, it doesn't cause weird visual issues?

@git-f0x git-f0x marked this pull request as draft November 25, 2024 02:15
@git-f0x git-f0x marked this pull request as ready for review November 25, 2024 02:29
@git-f0x git-f0x force-pushed the master branch 2 times, most recently from 6318d97 to a2e6e42 Compare November 25, 2024 03:29
@mmstick mmstick merged commit 8e823f6 into pop-os:master Nov 26, 2024
14 checks passed
@git-f0x git-f0x mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants