Nodejs14 Support #15
Open
Nodejs14 Support #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle was renamed to Local Object creation requires an isolate/Context so that the GC can clean it up In some places, requirement for isolate was changed to a context Maybe-objects need to be checked Values need to be unwrapped further with .Get() Calling on setters has to be checked (warning) Tested with nodejs 10, 12, 14
Handle was renamed to Local Object creation requires an isolate/Context so that the GC can clean it up In some places, requirement for isolate was changed to a context Maybe-objects need to be checked Values need to be unwrapped further with .Get() Calling on setters has to be checked (warning) Tested with nodejs 10, 12, 14
This was referenced May 18, 2020
Closed
johnkerl
added a commit
to johnkerl/node-iptrie
that referenced
this pull request
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With downward compatibility.
Used as aol/moloch wiseService needs it to become node14 compatible.