Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group #7 added translation docs #32

Merged
merged 4 commits into from
Jul 26, 2018
Merged

Group #7 added translation docs #32

merged 4 commits into from
Jul 26, 2018

Conversation

BestArya
Copy link
Contributor

This article introduces the definition of goroutine and common tools used to test it, which is very helpful for beginners in golang to avoid such common pitfalls. In particular, the article describe goroutine as a 'groundhog', while humorous, it makes the whole concept much easier to understand, even for non-professionals.

@zl117
Copy link

zl117 commented Jul 24, 2018 •
edited
Loading

comments from group 1:
For the long translation
This is a good example overall, but I think this translation can be improved.
"There are many groundhogs at your disposal" in the sentence 11, I know that this is from the Chinese version of this guideline, and this is a perfect version of direct translation. But according to my understanding, English speakers can be easily misguided by some of the phrases that we use, and also to prove my point, I have searched through the Internet, found 0 use of a phrase like this, not even to use a groundhog to do anything. I am aware of the fact that this is used as a metaphor, it will be better if we quote on this or give out the definition right after this sentence.
I am asking for advice from a native speaker. Please let me know if I am wrong, thank you!

@BestArya
Copy link
Contributor Author

Solved issue #24

MaoYiming0725
MaoYiming0725 reviewed Jul 24, 2018
View reviewed changes
blog-en/Testing of Goroutine Leak in PouchContainer.md

[PouchContainer](https://github.com/alibaba/pouch) is an open-source project created by Alibaba Group. It provides strong isolation and high portability, which can help enterprises quickly containerize their stock business and improve the utilization of internal physical resources.

PouchContainer is also a golang project in which goroutine has been widely used to implement management of various modules including containers, images, and logs. goroutine is an user-mode 'thread' supported by golang at the language level. This built-in feature can help developers build high-concurrency services at a rapid pace.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 5: goroutine is an user-mode 'thread' --> Goroutine is an user-mode 'thread'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/an user-mode/a user-mode?

a user rather than an user?

@allencloud
Copy link
Member

LGTM

@allencloud allencloud merged commit ca3178d into pouchcontainer:master Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaoYiming0725 MaoYiming0725 MaoYiming0725 left review comments

@allencloud allencloud allencloud left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BestArya @zl117 @allencloud @MaoYiming0725