Add 'install' make target #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povik
reviewed
Dec 9, 2024
Makefile
Outdated
| @@ -53,6 +54,10 @@ clean: clean-objects | |||
|
|
|||
| clean-all: clean clean-slang | |||
|
|
|||
| install: build/slang.so | |||
| $(YOSYS_CONFIG) --exec mkdir -p $(DESTDIR)$(PLUGINDIR) | |||
| $(YOSYS_CONFIG) --exec cp $< $(DESTDIR)$(PLUGINDIR) | |||
There was a problem hiding this comment.
We are invoking yosys-config both here and in the assignment to the PLUGINDIR variable, I think one of those is superfluous
There was a problem hiding this comment.
Welcome :-) I just simplified what is done at install. Let me know what you think or what your proposal is.
rodrigomelo9
force-pushed
the
add-install
branch
from
e9ea54d to
6ad55c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I recently discovered this project and added yosys-slang to one of my Dockerfiles (https://github.com/PyFPGA/containers/blob/main/recipes/synthesis). I noticed that this typical option was missing, so I added it, taking inspiration from the ghdl-yosys-plugin.