-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checkstyle printer #139
base: master
Are you sure you want to change the base?
Conversation
The ``--checkstyle-output`` option will generate a report in checkstyle xml format to the path specified by the option. | ||
|
||
The ``--extensions`` option lets you extend the code analysis. The provided extensions must be comma separated. | ||
|
||
**By default it analyses conditions, return statements, and switch cases.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line "**By default it analyses ~", was seemed to intended to add after --extensions
. So I move "The --extensions
~" line.
Would prefer this to be an output=xml or output=checkstyle. You could pass both flags currently which would be strange- Checkstyle is a great idea though |
|
||
public function printData(OutputInterface $output, FileReportList $fileReportList, HintList $hintList): void | ||
{ | ||
$output->writeln('Generate checkstyle report output...'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if these should be printed to stderr ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did find what you pointed :)
squizlabs/PHP_CodeSniffer#1612
I will try refactor (includes BC breaks) output format on another PR branch. |
I also see this as just a different output |
This PR requests adding checkstyle output feature.
I need checkstyle output to work with cs2pr, and other QA tools.
Notes: This PR also inclueds cs-fix