chore: optimize the useStatus hook and underlying isEqual #438
+25
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9d6b31b The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| statusChanged: (newStatus) => { | ||
| setSyncStatus(prev => { | ||
| // Only update if the status is actually different | ||
| return prev.isEqual(newStatus) ? prev : newStatus |
There was a problem hiding this comment.
The isEqual check should already be implemented here which should only cause the statusChanged listeners to be fired if the status actually changed. Is this necessary? If so there might be a different bug elsewhere.
There was a problem hiding this comment.
From my experience, when I use the useStatus hook from powersync my app refreshes every 5 seconds even if the status has not actually changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the 'spammy' useStatus behaviour
key changes:
JSON.stringifyalternative this is important since this is triggered often