Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename swift package name and add comment #4

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

DominicGBauer
Copy link
Contributor

@DominicGBauer DominicGBauer commented Dec 9, 2024

Description

This renames the Package to PowerSync and implements the renamed Kotlin-generated Swift SDK PowerSyncKotlin. It also adds explanatory comment that using "Returning *" in execute will result in an error.

Testing

I have run the app, logged in and completed some CRUD operations.

@DominicGBauer DominicGBauer self-assigned this Dec 9, 2024
@DominicGBauer DominicGBauer changed the title WIP chore: rename swift package name chore: rename swift package name and add comment Dec 9, 2024
@DominicGBauer DominicGBauer marked this pull request as ready for review December 9, 2024 17:31
Copy link

@mugikhan mugikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DominicGBauer DominicGBauer merged commit 049b276 into main Dec 10, 2024
1 check passed
@DominicGBauer DominicGBauer deleted the chore/rename-package branch December 10, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants