Result key order is now sorted by insertion time and not alphabetical #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aintain insertion order. The behaviour now matches other libraries.
Chriztiaan
changed the title
rkistner
reviewed
Nov 7, 2024
There was a problem hiding this comment.
It feels like there is some inefficiency in converting results from raw sqlite -> map<string, QuickValue> and then again to jsi::Object.
What about either:
1 Having the rows as vector<QuickValue> in the intermediate form (should have less overhead than the map, and you can pre-allocate each row vector with the correct size). OR:
2. Skip the intermediate value, and directly get each row as a jsi::Object.
It's only an optimization though - not sure how much of a difference this would make in practice. We can always leave that for later.
rkistner
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing
react-native-quick-sqlitewith adrizzlePoC, we found that RNQS sorts the keys in each row alphabetically instead of maintaining insertion order. This differs from web and OPsqlite and causes issues when depending on the order ofObject.keys/Object.values.This changeset changes the behaviour such that the metadata determines the order instead of the C++ map which causes the keys to be ordered alphabetically.