Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dc-avro lint #891

Closed
wants to merge 2 commits into from
Closed

feat: Add dc-avro lint #891

wants to merge 2 commits into from

Conversation

svdimchenko
Copy link

Add dc-avro to lint avro schemas in pre-commit

  • is added to the bottom or with existing repos from the same account
  • contains a license
  • is not language: system, language: script, language: docker, or language: docker_image
  • does not contain "pre-commit" in the name

@svdimchenko svdimchenko changed the title Feat/dc avro lint feat: Add dc-avro lint Oct 27, 2023
@asottile
Copy link
Member

your regex in your .pre-commit-hooks.yaml is not correct -- it would disallow files with whitespace in them

@svdimchenko
Copy link
Author

Current regex \S+\.avsc$ does not allow whitespace and that's OK for avro schema files. Could you provide and example when do you need to keep whitespace ?

@asottile
Copy link
Member

my schema.avsc

@svdimchenko
Copy link
Author

ah, I've never met such naming for avro schemas. So feel free to open an issue in corresponding repo.

@asottile asottile closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants