Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharethrough: declare support for oRTB 2.6 #3561

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

jefftmahoney
Copy link
Contributor

🔧 Type of changes

  • documentation
  • configuration

✨ What's the context?

Updating the bid adapter's configuration file (sharethrough.yaml).

🧠 Rationale behind the change

Making these changes so that publishers and other partners are aware that Sharethrough's exchange supports oRTB 2.6-compliant bid requests.

@AntoxaAntoxic
Copy link
Collaborator

Please fix the SharethroughTest, fix the test payload
from

  "regs": {
    "ext": {
      "gdpr": 0
    }
  }

to

  "regs": {
    "gdpr": 0
  }

@jefftmahoney
Copy link
Contributor Author

Please fix the SharethroughTest, fix the test payload from

  "regs": {
    "ext": {
      "gdpr": 0
    }
  }

to

  "regs": {
    "gdpr": 0
  }

Hello - I've updated the JSON file, but it looks like some tests are still failing in the pipeline.

Would it be possible for you or someone else on the Java team to take a quick look and just let me know if this is a pipeline snag or something I need to look at further in the adapter implementation? I honestly can't tell if its a CI/CD problem or related to my change.

@CTMBNara CTMBNara merged commit 77b1f6f into prebid:master Dec 3, 2024
7 checks passed
sergseven pushed a commit to openx/prebid-server-java that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: Sharethrough: Declare support for OpenRTB 2.6
4 participants