-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a typescript project to validate configuration using moduleResolution=bundler #580
feat: add a typescript project to validate configuration using moduleResolution=bundler #580
Conversation
@@ -23,7 +23,7 @@ jobs: | |||
with: | |||
repository: 'process-analytics/bpmn-visualization-js' | |||
# to test a specific feature under development, uncomment the following line and use the related branch | |||
# ref: 'specific_branch' | |||
ref: 'fix/package.json_exports_types' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO revert this when process-analytics/bpmn-visualization-js#2972 has been merged
[no ci]
"noEmit": true, | ||
"esModuleInterop": true, | ||
"module": "esnext", | ||
"moduleResolution": "bundler", // this configuration requires to have types declaration in the package.json "exports" attribute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"moduleResolution": "bundler", // this configuration requires to have types declaration in the package.json "exports" attribute | |
"moduleResolution": "bundler", // this configuration requires to have types declaration in the package.json "exports" field |
@@ -45,6 +45,7 @@ jobs: | |||
- javascript-vanilla-with-webpack | |||
- typescript-angular | |||
- typescript-lit-element | |||
- typescript-moduleResolution-bundler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until we have a released version of bpmn-visualization including the fix, we should exclude to build this project with the release version.
And restore it when the new release is available.
Closing, this reproduction project is going to be directly integrated in bpmn-visualization with process-analytics/bpmn-visualization-js#2972. |
WIP
Notes
This reproduces the issue mentioned in #390 (comment).