Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): replace 'plugin:@typescript-eslint/stylistic' by 'plugin:@typescript-eslint/stylistic-type-checked' rules #2822

Closed
wants to merge 5 commits into from

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Aug 25, 2023

ℹ️ See configs/stylistic-type-checked.ts for the exact contents of this config.

Covers #2742

@csouchet csouchet added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Aug 25, 2023
@csouchet csouchet force-pushed the 2742-use_stylistic-type-checked_rules branch from 8407178 to c734481 Compare August 28, 2023 09:53
@csouchet csouchet added the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Aug 28, 2023
@csouchet csouchet force-pushed the 2742-use_stylistic-type-checked_rules branch 2 times, most recently from e51525c to b7ca066 Compare August 29, 2023 12:39
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Aug 29, 2023
@csouchet csouchet force-pushed the 2742-use_stylistic-type-checked_rules branch 3 times, most recently from 0b75952 to 096361c Compare September 7, 2023 12:53
@csouchet csouchet force-pushed the 2742-use_stylistic-type-checked_rules branch from 096361c to 82a14ee Compare September 12, 2023 15:04
@csouchet csouchet added the poc 💫 Experimentation to discuss about future implementation. Not intended to be merged label Oct 4, 2023
0:1  error  This rule requires the `strictNullChecks` compiler option to be turned on to function correctly  @typescript-eslint/prefer-nullish-coalescing
@csouchet csouchet force-pushed the 2742-use_stylistic-type-checked_rules branch from 82a14ee to 869a7a8 Compare October 5, 2023 15:19
@csouchet
Copy link
Member Author

csouchet commented Oct 5, 2023

We don't want to implement it, because there is too many changes and errors. 
We just implement one rule: #2914

@csouchet csouchet closed this Oct 5, 2023
@csouchet csouchet added the decision record Track project and architectural decisions label Oct 5, 2023
@csouchet csouchet deleted the 2742-use_stylistic-type-checked_rules branch October 5, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) decision record Track project and architectural decisions poc 💫 Experimentation to discuss about future implementation. Not intended to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant