Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump the rollup group with 2 updates #2974

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 23, 2023

Bumps the rollup group with 2 updates: rollup and rollup-plugin-sizes.

Updates rollup from 4.5.0 to 4.5.1

Release notes

Sourced from rollup's releases.

v4.5.1

4.5.1

2023-11-21

Bug Fixes

  • Do not error when a function expression uses the same name for a parameter and its id (#5262)

Pull Requests

Changelog

Sourced from rollup's changelog.

4.5.1

2023-11-21

Bug Fixes

  • Do not error when a function expression uses the same name for a parameter and its id (#5262)

Pull Requests

Commits

Updates rollup-plugin-sizes from 1.0.5 to 1.0.6

Release notes

Sourced from rollup-plugin-sizes's releases.

v1.0.6

Patch Changes

Patch Changes

Changelog

Sourced from rollup-plugin-sizes's changelog.

1.0.5

1.0.6

Patch Changes

Patch Changes

1.0.4 (2021-02-26)

Bug Fixes

  • don't crash when module doesn't map to an input (#76) (881eada)

1.0.3 (2020-07-22)

1.0.2 (2020-03-18)

Bug Fixes

1.0.1 (2019-12-07)

1.0.0 (2019-12-07)

Features

  • better multi-bundle support (78be22b)
  • update deprecated ongenerate hook to generateBundle (#15) (f2df7a8)

BREAKING CHANGES

  • rollup@1 is required to use the generateBundle hook

0.5.1 (2019-02-25)

0.5.0 (2019-02-25)

Bug Fixes

0.4.2 (2017-11-01)

0.4.1 (2017-11-01)

... (truncated)

Commits
  • 4eac1d4 Version Packages (#179)
  • 2ba0ba1 feat: add rollup@4 support (#178)
  • d41acd7 chore(deps-dev): bump rollup from 3.29.4 to 4.2.0 (#176)
  • 4566ea1 Update ci.yml
  • 6452d07 chore(deps-dev): bump eslint from 8.50.0 to 8.52.0 (#177)
  • 20a22fc chore(deps-dev): bump @​babel/traverse from 7.18.9 to 7.23.2 (#175)
  • a35a612 chore(deps-dev): bump eslint from 8.48.0 to 8.50.0 (#173)
  • 71d7122 chore(deps-dev): bump rollup from 3.28.1 to 3.29.4 (#172)
  • 19c6886 chore(deps-dev): bump rollup from 3.27.0 to 3.28.1 (#170)
  • 2a102b0 chore(deps-dev): bump eslint from 8.46.0 to 8.48.0 (#171)
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the rollup group with 2 updates: [rollup](https://github.com/rollup/rollup) and [rollup-plugin-sizes](https://github.com/tivac/rollup-plugin-sizes).


Updates `rollup` from 4.5.0 to 4.5.1
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.5.0...v4.5.1)

Updates `rollup-plugin-sizes` from 1.0.5 to 1.0.6
- [Release notes](https://github.com/tivac/rollup-plugin-sizes/releases)
- [Changelog](https://github.com/tivac/rollup-plugin-sizes/blob/main/CHANGELOG.md)
- [Commits](tivac/rollup-plugin-sizes@v1.0.5...v1.0.6)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: rollup
- dependency-name: rollup-plugin-sizes
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: rollup
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency (dev or runtime) javascript Pull requests that update Javascript code skip-changelog Do not include in Changelog and Release Notes labels Nov 23, 2023
@dependabot dependabot bot requested review from a team, csouchet, tbouffard and oanesini and removed request for a team November 23, 2023 12:38
@tbouffard
Copy link
Member

Convert to draft. I would like to manage #2928 as part of this PR.

@tbouffard tbouffard marked this pull request as draft November 23, 2023 12:46
Copy link

github-actions bot commented Nov 23, 2023

🎊 PR Preview 9415491 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-2974.surge.sh

🕐 Build time: 0.011s

🤖 By surge-preview

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

github-actions bot commented Nov 23, 2023

🎊 PR Preview 9415491 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-2974.surge.sh

🕐 Build time: 0.011s

🤖 By surge-preview

Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ All checks pass
✔️ Changelog and release-notes reviewed. rolling-plugin-sizes add supports for rollup@4, so it is possible to manage #2928.

This plugin correcly works with rollup@4. Tested locally by running npm run build-bundles

src/bpmn-visualization.ts:
mxgraph - 2.27 MB (85.90%)
app - 287.22 kB (10.85%)
fast-xml-parser - 62.84 kB (2.37%)
lodash-es - 16.89 kB (0.64%)
strnum - 4.82 kB (0.18%)
rollup helpers - 1.55 kB (0.06%)

Notes

The npm install command generates warnings that seems non blocking for now:

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @rollup/[email protected]
npm WARN Found: [email protected]
npm WARN node_modules/rollup
npm WARN   dev rollup@"~4.5.1" from the root project
npm WARN   8 more (@rollup/plugin-commonjs, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peerOptional rollup@"^1.20.0||^2.0.0||^3.0.0" from @rollup/[email protected]
npm WARN node_modules/@rollup/plugin-commonjs/node_modules/@rollup/pluginutils
npm WARN   @rollup/pluginutils@"^5.0.1" from @rollup/[email protected]
npm WARN   node_modules/@rollup/plugin-commonjs
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/rollup
npm WARN   peerOptional rollup@"^1.20.0||^2.0.0||^3.0.0" from @rollup/[email protected]
npm WARN   node_modules/@rollup/plugin-commonjs/node_modules/@rollup/pluginutils
npm WARN     @rollup/pluginutils@"^5.0.1" from @rollup/[email protected]
npm WARN     node_modules/@rollup/plugin-commonjs
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @rollup/[email protected]
npm WARN Found: [email protected]
npm WARN node_modules/rollup
npm WARN   dev rollup@"~4.5.1" from the root project
npm WARN   8 more (@rollup/plugin-commonjs, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peerOptional rollup@"^1.20.0||^2.0.0||^3.0.0" from @rollup/[email protected]
npm WARN node_modules/@rollup/plugin-node-resolve/node_modules/@rollup/pluginutils
npm WARN   @rollup/pluginutils@"^5.0.1" from @rollup/[email protected]
npm WARN   node_modules/@rollup/plugin-node-resolve
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/rollup
npm WARN   peerOptional rollup@"^1.20.0||^2.0.0||^3.0.0" from @rollup/[email protected]
npm WARN   node_modules/@rollup/plugin-node-resolve/node_modules/@rollup/pluginutils
npm WARN     @rollup/pluginutils@"^5.0.1" from @rollup/[email protected]
npm WARN     node_modules/@rollup/plugin-node-resolve

@tbouffard
Copy link
Member

tbouffard commented Nov 23, 2023

@dependabot squash and merge

@tbouffard tbouffard linked an issue Nov 23, 2023 that may be closed by this pull request
@tbouffard tbouffard marked this pull request as ready for review November 23, 2023 13:29
@dependabot dependabot bot merged commit fc584c2 into master Nov 23, 2023
22 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/rollup-9d9831fb55 branch November 23, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency (dev or runtime) javascript Pull requests that update Javascript code skip-changelog Do not include in Changelog and Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INFRA] Remove legacy-peer-deps=true from .npmrc when possible
1 participant