fix: ensure numeric attributes are parsed as number #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The XML parser now ensures that the following elements have numeric attributes
- bounds of shapes
- label bounds of shapes and edges
- waypoints of edges
Previously, when the attribute contained too many decimals, the value was converted to a string instead of a number.
Existing tests exhibited this behavior; they have been modified and enriched to cover all use cases and show that the
issue is now fixed.
A high-level parsing test has also been added to use the diagram that was provided by the community to show the past
problem.
|
🎊 PR Preview b2f4da5 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-3040.surge.sh 🕐 Build time: 0.012s
🤖 By surge-preview |
|
🎊 PR Preview b2f4da5 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-3040.surge.sh 🕐 Build time: 0.012s
🤖 By surge-preview |
|
tbouffard
commented
Feb 21, 2024
test/unit/component/parser/xml/BpmnXmlParser.itp-commerce.7-7151-18707.test.ts
Outdated
Show resolved
Hide resolved
test/unit/component/parser/xml/BpmnXmlParser.itp-commerce.7-7151-18707.test.ts
Outdated
Show resolved
Hide resolved
[skip ci]
csouchet
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XML parser now ensures that the following elements have numeric attributes
Previously, when the attribute contained too many decimals, the value was converted to a string instead of a number. Existing tests exhibited this behavior; they have been modified and enriched to cover all use cases and show that the issue is now fixed.
A high-level parsing test has also been added to use the diagram that was provided by the community to show the past problem.
closes #2857
Screencasts
Using the diagram provided to exhibit the issue in #2857
issue_2857_fix.mp4