feat: render annotation + association defined in "collaboration” #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also detect associations Fix some documentation
WIP add test to reproduce the current behavior - improve types test association: comment unused code association test: refactor to introduce utility function test association: add tests to reproduce the current behaviour association: add CollaborationConverter.ts buildAssociationFlows association: implem test association: various refactorings extract function association: add TODO association tests: clean commented code association tests: check both collaboration and process association: simplify tests bpmn-model-expect.ts: update comment association: ProcessConverter.ts - remove extra method
WIP refactor test text annotation WIP refactor test text annotation: avoid bounds duplication WIP refactor test text annotation: avoid bounds duplication - improve signature of util function WIP refactor test text annotation: avoid bounds duplication - more usage WIP refactor test text annotation: avoid bounds duplication - rename util function test text annotation: single in collaboration text annotation: 1st implementation test text annotation: arrays in collaboration test text annotation: refactor test text annotation: refactor (not pass shapeId to utility function) text annotation: fix test title text annotation: remove commented code + add TODO text annotation tests: check incomings and outgoings text annotation tests: check incomings and outgoings - refactor text annotation: CollaborationConverter.ts - remove commented code text annotation: refactor CollaborationConverter.ts
tbouffard
added
enhancement
|
🎊 PR Preview 38a81e1 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-3200.surge.sh 🕐 Build time: 0.011s
🤖 By surge-preview |
|
🎊 PR Preview 38a81e1 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-3200.surge.sh 🕐 Build time: 0.01s
🤖 By surge-preview |
|
tbouffard
commented
Oct 23, 2024
|
ℹ️ The issue spotted by SonarCloud (remaining TODO) has been fixed in 44e0156 |
csouchet
approved these changes
Oct 23, 2024
tbouffard
changed the title
tbouffard
deleted the
feat/2635-2637_text-annotation_defined_in_collaboration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change involve introducing utility functions into tests to simplify the writing of code for setup and expectation in JSON parsing tests.
Also fix some collaborators' documentation about the BPMN support.
Notes
closes #2635
closes #2637