Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redirect the page for the model generation app conditions #1179

Closed
wants to merge 4 commits into from

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Oct 9, 2023

ℹ️ Based on our team's decision, we no longer require approval of the refactoring pull request. Instead, we will review and approve the refactoring once all changes related to a specific component have been completed.

To test: https://process-analytics-process-analytics-dev-site_preview-pr-1179.surge.sh/model-generation-application-conditions

Covers #1170

@csouchet csouchet added the enhancement New feature or request label Oct 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

♻️ PR Preview 40ca544 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@csouchet csouchet marked this pull request as ready for review October 10, 2023 07:59
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://process-analytics-process-analytics-dev-site_preview-pr-1179.surge.sh/model-generation-application-conditions returns a 404 HTTP code, displays the 404 error page, then a blank page. The final URL in the browser is https://process-analytics-process-analytics-dev-site_preview-pr-1179.surge.sh/
Tested on Ubuntu 20.04 with Chrome 117.0.5938.149 and Firefox 118.0.1

We don't want to return a HTTP 404, but a 200 or 301.

I suggest to redirect to the model-generation application, if possible by first returning a 301 and the target page, or if not, internally displays the target page and returns HTTP 200

@csouchet
Copy link
Member Author

⚠️ The redirect works, but when it first loads, it displays a blank page.
When you refresh it or try to go to the old page again, the new page is displayed.

I've tried redirecting to the /model-generation-application page instead of the home page, but I get the same problem.

I suggest keeping the default redirect page: /404.
There's a link to go back to home or select the page the user is interested in.

@csouchet
Copy link
Member Author

See my previous comment

@csouchet csouchet closed this Oct 12, 2023
@csouchet csouchet deleted the redirect_condition_page branch October 12, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants